fix: #23986 [Comment] Should not render avatar wrapper when avatar is… #23994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 89abc8f:
|
|
这个组件难得有更新。😹 |
|
@afc163 大佬有空review 一下🙇♂️ |
|
|
Codecov Report
@@ Coverage Diff @@
## master #23994 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 364 364
Lines 7270 7272 +2
Branches 2024 2028 +4
=======================================
+ Hits 7181 7183 +2
Misses 89 89
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Closes: #23986
💡 Background and solution
When avatar prop of Comment not present, it will render an empty wrapper div with css class "ant-comment-avatar" which is hold style
margin-right: 12px;, so12pxblank space left there to broken the page style.So, this PR just remove this
empty wrapper divas render nothing when avatar not provide.📝 Changelog
avatar为空时，不再渲染空白的包装div，避免影响页面样式☑️ Self Check before Merge