Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: fix Button loading not smooth #23783

Merged
merged 1 commit into from
Apr 30, 2020
Merged

improvement: fix Button loading not smooth #23783

merged 1 commit into from
Apr 30, 2020

Conversation

shaodahong
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Resolve #23780

Before:

Kapture 2020-04-30 at 16 55 11

After:

Kapture 2020-04-30 at 16 54 30

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Button loading animation
🇨🇳 Chinese 修复 Button loading 动画

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@shaodahong shaodahong changed the title improve: fix Button loading not smooth improvement: fix Button loading not smooth Apr 30, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 30, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa5a583:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #23783 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23783   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         364      364           
  Lines        7258     7258           
  Branches     1974     1974           
=======================================
  Hits         7152     7152           
  Misses        106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5d09d...fa5a583. Read the comment docs.

@Loving-Vincent
Copy link

windows环境下依旧卡顿,loading时icon是突然弹出来的,和上面gif中的效果不一样。官网Demo可以复现。

button

Environment Info
Windows 10
Chrome 81.0

@shaodahong
Copy link
Member Author

windows环境下依旧卡顿,loading时icon是突然弹出来的,和上面gif中的效果不一样。官网Demo可以复现。

button

Environment Info
Windows 10
Chrome 81.0

手上暂时没有 win 的机器,麻烦看下4.2.1 这个版本有问题么

@shaodahong
Copy link
Member Author

Kapture 2020-05-20 at 20 26 19

@Loving-Vincent 用虚拟机的 Windows 试了下发现 4.2.1 的版本是好的,可能是后面的改坏了,需要排查下

@Loving-Vincent
Copy link

嗯嗯,4.2.1版本是正常的。我先退回这个版本。

@Loving-Vincent
Copy link

嗯嗯,4.2.1版本是正常的。我先退回这个版本。

4.2.1版本好像有bug,换上了4.2.2版本,没有卡顿问题了😃。

@shaodahong
Copy link
Member Author

嗯嗯,4.2.1版本是正常的。我先退回这个版本。

4.2.1版本好像有bug,换上了4.2.2版本,没有卡顿问题了😃。

什么 bug,可以在这里讨论 #24323

@Loving-Vincent
Copy link

我在antd的github releases里面看到的,安装4.2.1版本时会报错,在4.2.2版本中修复了。

@yoyo837
Copy link
Contributor

yoyo837 commented May 20, 2020

我在antd的github releases里面看到的,安装4.2.1版本时会报错,在4.2.2版本中修复了。

和该功能没有关系。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need improve Button loading
5 participants