Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix table row select style in rtl #23690

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 28, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

  • 很奇怪,这块的 基本样式 是改动过吧,感觉以前是 好着的啊

before

image

After

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Table rowSelect icon style in RTL
🇨🇳 Chinese 修复 Table rowSelect 按钮 RTL 样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@hengkx
Copy link
Member

hengkx commented Apr 28, 2020

能把css输出结果 一起当成测试么

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 28, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ada0e0:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #23690 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23690   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         363      363           
  Lines        7199     7199           
  Branches     1952     1952           
=======================================
  Hits         7091     7091           
  Misses        108      108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62eaa41...3ada0e0. Read the comment docs.

@afc163 afc163 merged commit 5183592 into master Apr 28, 2020
@afc163 afc163 deleted the fix-table-row-select-rtl branch April 28, 2020 01:55
@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 28, 2020

能把css输出结果 一起当成测试么

有的 可能就是更换了 原有的css 方式,优化了输出效果,这样测试也不好整

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants