Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up when field reset removed #23041

Merged
merged 1 commit into from
Apr 8, 2020
Merged

fix: clean up when field reset removed #23041

merged 1 commit into from
Apr 8, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23035

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item not correct reset error style when dynamic switch Form.Item.
🇨🇳 Chinese 修复 Form.Item 在动态切换时没有正确重置错误样式的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

tests-checker[bot]
tests-checker bot suggested changes Apr 8, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 8, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ee7cbcc:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #23035

@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited
Loading

Codecov Report

Merging #23041 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23041      +/-   ##
==========================================
+ Coverage   98.32%   98.36%   +0.04%     
==========================================
  Files         364      364              
  Lines        7262     7265       +3     
  Branches     1993     1992       -1     
==========================================
+ Hits         7140     7146       +6     
+ Misses        122      119       -3
Impacted Files Coverage Δ
components/form/FormItemInput.tsx 94.11% <100.00%> (+0.56%) ⬆️
components/carousel/index.tsx 100.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9713bf...ee7cbcc. Read the comment docs.

@zombieJ zombieJ merged commit 70eaea6 into master Apr 8, 2020
@zombieJ zombieJ deleted the form-err branch April 8, 2020 10:48
@afc163 afc163 mentioned this pull request Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form 样式在动态表单字段中存在 bug
2 participants
@zombieJ @ant-design-bot