Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Table header columns size with filter or sorter #22872

Merged
merged 7 commits into from
Apr 3, 2020
Merged

fix: Table header columns size with filter or sorter #22872

merged 7 commits into from
Apr 3, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 3, 2020 •
edited by markdownify bot
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22866
fix #22777
close #22838

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table header size with filter or sorter when size is configured.
🇨🇳 Chinese 修复 Table 配 size 时，使用过滤和排序的表头尺寸问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/dynamic-settings.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 3, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 381aaff:

Sandbox Source
antd reproduction template Configuration
紧凑型 - Ant Design Demo Issue #22777
紧凑型 - Ant Design Demo Issue #22777

@zombieJ zombieJ requested review from afc163 and AshoneA April 3, 2020 04:11
@AshoneA AshoneA mentioned this pull request Apr 3, 2020
Closed
14 tasks
@AshoneA
Copy link
Contributor

AshoneA commented Apr 3, 2020

#22838 (comment)

and hover background color.

@codecov
Copy link

codecov bot commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #22872 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22872   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         363      363           
  Lines        7244     7244           
  Branches     1977     1987   +10     
=======================================
  Hits         7122     7122           
  Misses        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b77e61...381aaff. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Apr 3, 2020

image

最后一个例子这里，filters 为空时是不是放个 Empty 好了。

@AshoneA
Copy link
Contributor

AshoneA commented Apr 3, 2020

其他应该 OK 了。

@zombieJ
Copy link
Member Author

zombieJ commented Apr 3, 2020

截屏2020-04-03 下午1 06 44

还要调整一下，拓展出去的 padding 会挡住前面的 filter。

@AshoneA
Copy link
Contributor

AshoneA commented Apr 3, 2020

还要调整一下，拓展出去的 padding 会挡住前面的 filter。

这是我觉得这种实现怪怪的感觉， 这里 #22838 我改动了这种布局方式，不过就是 Tooltip 触发区域不是整块表头了...

@zombieJ
Copy link
Member Author

zombieJ commented Apr 3, 2020

还要调整一下，拓展出去的 padding 会挡住前面的 filter。

这是我觉得这种实现怪怪的感觉， 这里 #22838 我改动了这种布局方式，不过就是 Tooltip 触发区域不是整块表头了...

点击排序的区域是整个，tooltip 应该也是全部覆盖。

@zombieJ
Copy link
Member Author

zombieJ commented Apr 3, 2020

done. Check agagin.

@zombieJ zombieJ merged commit 1e5c527 into master Apr 3, 2020
@zombieJ zombieJ deleted the fix-columns branch April 3, 2020 05:42
@afc163
Copy link
Member

afc163 commented Apr 3, 2020

dist 测试挂了

@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Merged
@collinbarrett collinbarrett mentioned this pull request Apr 6, 2020
Closed
@xrkffgg xrkffgg mentioned this pull request Jun 22, 2020
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshoneA AshoneA AshoneA approved these changes

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Padding of column title is broken on small sized table when filter is enabled Table columns 大小变化
4 participants
@zombieJ @ant-design-bot @AshoneA @afc163