fix: Fix order of operations for tooltipPlacement #22772
Conversation
tooltipPlacement was broken by ant-design@a6c207d. The grouping of this term was getting parsed as `(tooltipPlacement || vertical) ? 'right' : 'top'`, which was incorrect.
|
One test fails, but I believe it was failing before my change. |
yoyo837
changed the title
|
|
|
@wendellhu95 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a392930:
|
Codecov Report
@@ Coverage Diff @@
## master #22772 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 361 361
Lines 7212 7212
Branches 1971 1934 -37
=======================================
Hits 7088 7088
Misses 124 124
Continue to review full report at Codecov.
|
|
Wow, nice turnaround time. This could probably use a regression test, but I wasn't familiar enough with the testing library to want to figure it out for this. Up to y'all whether to add one. |
|
@wendellhu95 Could you add a test case about |
OK. I will do that. |
🤔 This is a ...
🔗 Related issue link
No issue was created.
💡 Background and solution
tooltipPlacement was broken by a6c207d.
The grouping of this term was getting parsed as
(tooltipPlacement || vertical) ? 'right' : 'top', which was incorrect.📝 Changelog
☑️ Self Check before Merge