Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export form value type #22755

Merged
merged 1 commit into from
Apr 6, 2020
Merged

chore: export form value type #22755

merged 1 commit into from
Apr 6, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 30, 2020 •
edited by zombieJ
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22905

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

tests-checker[bot]
tests-checker bot suggested changes Mar 30, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 30, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit efd102a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #22755 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22755   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         360      360           
  Lines        7213     7213           
  Branches     1982     1981    -1     
=======================================
  Hits         7089     7089           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4668f3...efd102a. Read the comment docs.

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 2, 2020

我感觉StoreValue支持范型会不会好些，虽然和本PR无关。

@shaodahong
Copy link
Member Author

Ref: https://github.com/shaodahong/ant-design-admin/blob/5c85a100244bbce54bc429c13e790e4cea781f52/components/form/index.tsx#L10

@shaodahong shaodahong mentioned this pull request Apr 3, 2020
Merged
@yoyo837 yoyo837 mentioned this pull request Apr 3, 2020
Closed
1 task
@zombieJ
Copy link
Member

zombieJ commented Apr 6, 2020

这个先合了，泛型有个 PR 可以继续跟进。

@zombieJ zombieJ merged commit c4fb9ed into ant-design:master Apr 6, 2020
@shaodahong shaodahong deleted the export-form-value-type branch April 6, 2020 03:42
@afc163 afc163 mentioned this pull request Apr 10, 2020
Merged
This was referenced Aug 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form add typescript type Store
4 participants
@shaodahong @ant-design-bot @yoyo837 @zombieJ