Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 💄 @info-color should be @primary-color defaultly #22723

Merged
merged 1 commit into from
Apr 1, 2020
Merged

style: 💄 @info-color should be @primary-color defaultly #22723

merged 1 commit into from
Apr 1, 2020

Conversation

kaoding
Copy link
Contributor

@kaoding kaoding commented Mar 29, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Mar 29, 2020

#5442

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 29, 2020

@kaoding
Copy link
Contributor Author

kaoding commented Mar 29, 2020

#5442

我觉得 info 色默认跟随是更合理的,success,error等有明确的指示状态,默认定义为状态色,info默认不一定是佛晓蓝,跟随自定义的主题会更好一些,就算跟随主题,用户也还是可以自定义的。

@afc163
Copy link
Member

afc163 commented Mar 29, 2020

主色是绿色/红色/黄色就会比较麻烦。

@kaoding
Copy link
Contributor Author

kaoding commented Mar 29, 2020

image
对比
image
可以问一问设计的同学

@kaoding
Copy link
Contributor Author

kaoding commented Mar 29, 2020

主色是绿色/红色/黄色就会比较麻烦。

这也是一个问题,碰到这种情况就要修改 info 色了。

@afc163
Copy link
Member

afc163 commented Mar 29, 2020

@pasturn

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3db9c68:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #22723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22723   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         360      360           
  Lines        7221     7221           
  Branches     1937     1984   +47     
=======================================
  Hits         7086     7086           
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a9d6cd...3db9c68. Read the comment docs.

@afc163 afc163 changed the title 信息提示色默认跟随主色 style: @info-color should be @primary-color defaultly Apr 1, 2020
@afc163 afc163 changed the title style: @info-color should be @primary-color defaultly style: 💄 @info-color should be @primary-color defaultly Apr 1, 2020
@afc163 afc163 merged commit 3f8dbc5 into ant-design:master Apr 1, 2020
@afc163 afc163 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants