Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Table pagination position add more option #22647

Merged
merged 4 commits into from
Mar 27, 2020
Merged

feat: Table pagination position add more option #22647

merged 4 commits into from
Mar 27, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Mar 26, 2020 •
edited by markdownify bot
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

https://github.com/ant-design/ant-design/pull/11232/files/4fe523a5c552972a7af9bebc7407f50207857c94#diff-7c42f83174d9260d6dfd7bc226b5d8c7

💡 Background and solution

close #11213
image

📝 Changelog

Language Changelog
🇺🇸 English Table pagination position add more option
🇨🇳 Chinese 表格分页位置增加更多选项

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/pagination.md
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md

tests-checker[bot]
tests-checker bot suggested changes Mar 26, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 26, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 26, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51802f0:

Sandbox Source
antd reproduction template Configuration

@hengkx
Copy link
Member Author

hengkx commented Mar 26, 2020

奇怪啊 table 我本地的单元测试是通过的 ci 怎么还是报错

@hengkx hengkx requested review from zombieJ and afc163 March 26, 2020 21:42
@afc163
Copy link
Member

afc163 commented Mar 27, 2020

/rebase

@hengkx
Copy link
Member Author

hengkx commented Mar 27, 2020

@afc163 这个pr需要怎么处理，可以说详细点吗？

@afc163
Copy link
Member

afc163 commented Mar 27, 2020

等 master 合并到 feature，再 rebase 一下 feature

#22517

@afc163
Copy link
Member

afc163 commented Mar 27, 2020

可以了，rebase 一下。

@hengkx
Copy link
Member Author

hengkx commented Mar 27, 2020

done

@afc163 afc163 merged commit fa030a6 into ant-design:feature Mar 27, 2020
@hengkx hengkx deleted the feat-11213 branch March 27, 2020 08:30
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Merged
@hengkx hengkx mentioned this pull request Apr 27, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@afc163 afc163 afc163 approved these changes

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hengkx @ant-design-bot @afc163