fix: gapDegree=0 in Dashboard progress is now working #22462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a201ce5:
|
|
Also, the default value in progrss.jsx has changed from |
|
来个用例吧。 |
OK, I will work on it~ |
Done. Also a question, it's weird that gapDegree only support up to 295 rather than 359 (or 360), I think it might be some issue within rc-progress. By far I have corrected the default value in API doc, and I will explore this issue in future. |
thisrabbit
changed the title
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#22347
💡 Background and solution
Problem: API defination about
Progressis partial wrong (the default value), and also gapDegree=0 intype="dashboard"won't make effect.Fix: by polishing the API doc and updating code about
gapDeg.📝 Changelog
Dashboard Progresswon't allow gapDeg to be 0☑️ Self Check before Merge
View rendered components/progress/demo/segment.md
View rendered components/progress/index.en-US.md
View rendered components/progress/index.zh-CN.md