Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 empty disabled Button align issue #22461

Merged
merged 2 commits into from
Mar 21, 2020
Merged

fix: 🐛 empty disabled Button align issue #22461

merged 2 commits into from
Mar 21, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 21, 2020 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22453

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button align issue when is disabled and wrapped by Tooltip .
🇨🇳 Chinese 修复 Button 为 disabled 时被 Tooltip 包裹时的对齐问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title Fix tooltip disabled wrapper fix: empty disabled Button align issue Mar 21, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 21, 2020 •
edited
Loading

@afc163 afc163 changed the title fix: empty disabled Button align issue fix: 🐛 empty disabled Button align issue Mar 21, 2020
@shaodahong
Copy link
Member

主干上的测试挂了，包也胀了

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd5222f:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member Author

afc163 commented Mar 21, 2020

主干上的测试挂了

npm test -- --coverage 本地可重现，原因未知。

包也胀了

原因未知，可能和 babel 发布有关。

@afc163 afc163 merged commit 4fcc6f6 into master Mar 21, 2020
@afc163 afc163 deleted the fix-tooltip-disabled-wrapper branch March 21, 2020 06:30
This was referenced Mar 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disabled Button with Tooltip has a span wrapper, which affects css selector
3 participants
@afc163 @ant-design-bot @shaodahong