Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ant Table Border Radius #22413

Merged
merged 1 commit into from
Mar 20, 2020
Merged

fix: Ant Table Border Radius #22413

merged 1 commit into from
Mar 20, 2020

Conversation

akshatmittal
Copy link
Contributor

@akshatmittal akshatmittal commented Mar 19, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Ant Table shows white background on the edges instead of proper border-radius.

💡 Background and solution

Ant does not apply border-radius to table container element leading to a white background on the edges (instead of the correct border radius).

image

Solution: Add border-radius to table container element.

image

📝 Changelog

Does not break anything.

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@akshatmittal akshatmittal changed the title Fix Ant Table Border Radius fix: Ant Table Border Radius Mar 19, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 19, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e24ba6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #22413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22413   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         306      306           
  Lines        7061     7061           
  Branches     1928     1893   -35     
=======================================
  Hits         6926     6926           
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3ddb2...4e24ba6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants