-
-
Notifications
You must be signed in to change notification settings - Fork 50.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#16762): should use cachedOptions when filtered options don't cange #22216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4bbd7b0:
|
Codecov Report
@@ Coverage Diff @@
## master #22216 +/- ##
==========================================
+ Coverage 97.92% 97.95% +0.02%
==========================================
Files 306 306
Lines 7042 7044 +2
Branches 1928 1939 +11
==========================================
+ Hits 6896 6900 +4
+ Misses 146 144 -2
Continue to review full report at Codecov.
|
The problem is that the search options always generates new, even when the options has not changed, causing component always re-render. |
In progress? |
I try it in my local, this line is be covered. |
🤔 This is a ...
🔗 Related issue link
close #16762
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge