Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fr_FR locale in date_picker #22122

Merged
merged 1 commit into from
Mar 11, 2020
Merged

fix: fr_FR locale in date_picker #22122

merged 1 commit into from
Mar 11, 2020

Conversation

PaulJln
Copy link
Contributor

@PaulJln PaulJln commented Mar 11, 2020 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Issue link

💡 Background and solution

Open antd/lib/date-picker/locale/fr_FR.d.ts and antd/lib/date-picker/locale/en_US.d.ts, type lang looks different, some params are missing in the French locale file.

yearPlaceholder: string;
monthPlaceholder: string;
weekPlaceholder: string;
rangePlaceholder: string[];
rangeYearPlaceholder: string[];
rangeMonthPlaceholder: string[];
rangeWeekPlaceholder: string[];

Solution:

Add missing parameters in components/date-picker/locale/fr_FR.tsx

⚠️ I think more changes will have to be made in all other locals except en_US and zh_CN. Unfortunately I don't have the language skills to do them all. ⚠️

📝 Changelog

Language Changelog
🇺🇸 English fix typing in fr_FR locale date_picker
🇨🇳 Chinese 修复在fr_FR“ locale” date_picker中键入

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 11, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46f3676:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #22122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22122   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7042     7042           
  Branches     1939     1939           
=======================================
  Hits         6899     6899           
  Misses        143      143
Impacted Files Coverage Δ
components/date-picker/locale/fr_FR.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909bde6...46f3676. Read the comment docs.

@afc163 afc163 merged commit e989683 into ant-design:master Mar 11, 2020
@chenshuai2144 chenshuai2144 mentioned this pull request Mar 14, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2020
Closed
@PaulJln PaulJln mentioned this pull request Mar 27, 2020
Closed
1 task
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulJln @ant-design-bot @afc163