Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Table filter menu reset not working #22079

Merged
merged 2 commits into from
Mar 10, 2020
Merged

fix: Table filter menu reset not working #22079

merged 2 commits into from
Mar 10, 2020

Conversation

shaodahong
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Resolve #22075

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Table filter menu reset not working
🇨🇳 Chinese 修复 Table filter 菜单重置失效

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 10, 2020 •
edited
Loading

@afc163 afc163 requested a review from zombieJ March 10, 2020 12:29
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 10, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 707dc6a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 10, 2020 •
edited
Loading

Codecov Report

Merging #22079 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22079      +/-   ##
==========================================
+ Coverage   97.96%   97.96%   +<.01%     
==========================================
  Files         306      306              
  Lines        7038     7039       +1     
  Branches     1937     1937              
==========================================
+ Hits         6895     6896       +1     
  Misses        143      143
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 95.83% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3670ca7...707dc6a. Read the comment docs.

@zombieJ zombieJ merged commit 924f1cf into ant-design:master Mar 10, 2020
@shaodahong shaodahong deleted the fix-table-filter-reset branch March 10, 2020 13:29
@chenshuai2144 chenshuai2144 mentioned this pull request Mar 14, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Closed
This was referenced Mar 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table filter menu reset not working
3 participants
@shaodahong @ant-design-bot @zombieJ