-
-
Notifications
You must be signed in to change notification settings - Fork 50.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: basic form style abnormal #21907
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a81e977:
|
rebase |
Codecov Report
@@ Coverage Diff @@
## master #21907 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 306 306
Lines 7039 7039
Branches 1927 1937 +10
=======================================
Hits 6896 6896
Misses 143 143 Continue to review full report at Codecov.
|
之前 label 为啥又从 |
按照现在这个 flex 的标准迁移吧,以后有问题也往 flex 去靠,以前的 grid flex 模式就有问题,所以后来调的时候和 v3 很多的不兼容,现在这个我试了下应该是可以的 |
@zombieJ 这个让我先弄弄,我把规则整一整,不然以后还会出问题 |
我的意思是兼容包的样式就在 |
嗯,兼容包的问题我会改,现在 V4 现在的也有问题,你看下这个 https://codesandbox.io/s/lingering-cloud-xdkmo Demo,点击 col-4 会触发 aotu 区域的 click |
Recording对于 V3 Grid 的异常布局进行优化。 Grid 是基于 24 栅格(zha'ge)(Col GridFormForm 利用 Grid 排列 Label 和 Input 实现 <Form>
<Form.Item>
<Row>
<Col>Label</Col>
<Col>Input</Col>
</Row>
</Form>
|
什么时候修复上线 |
@LJJCherry 每周会发布一个 patch,下周应该就能看到 |
@shaodahong @afc163 这个 PR 产生了 breaking change 从v4.0.2升级到 v4.0.3 样式错乱 如果, |
@kagawagao 4.0.2 的是 Bug,4.0.3 是对的,参考 #21907 (comment) |
@shaodahong 这个改动对之前的代码影响很大的,我觉得不应该是一个 patch 从上面的 demo 中,也可以看到,这个影响到了布局,凡是之前是这样子使用的,都会产生影响。 |
我还是认为,在指定 |
嗯,默认 Flex 是不自动伸展的 对之前的代码影响很大我能问下哪些方面,如果只是单纯的没必要用上 Grid 吧 <Row>
<Col><Button /></Col>
<Col><Button /></Col>
</Row> |
这只是个 demo,实际上使用的时候当然不是这个样子 我发现的影响的点目前就是 demo 中所体现的 |
晚上确认下 |
@LJJCherry 提供下 Demo? |
https://codesandbox.io/s/antd-reproduction-template-8t7bl 嘻嘻嘻嘻~ |
🤔 This is a ...
🔗 Related issue link
resolve #21903
resolve #22009
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge