fix: React 16.13 warning #21702
Merged
fix: React 16.13 warning #21702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afc163
reviewed
Feb 29, 2020
| setInlineErrors({ | ||
| ...inlineErrors, | ||
| [subName]: subErrors, | ||
| Promise.resolve().then(() => { |
There was a problem hiding this comment.
上层 Form.Item 不在乎何时收到消息。所以顶层延迟掉。
There was a problem hiding this comment.
不用，消息通知越快越好。不用等 DOM render。
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e4ee20a:
|
Codecov Report
@@ Coverage Diff @@
## master #21702 +/- ##
==========================================
+ Coverage 97.88% 97.88% +<.01%
==========================================
Files 305 305
Lines 6998 6999 +1
Branches 1933 1887 -46
==========================================
+ Hits 6850 6851 +1
Misses 148 148
Continue to review full report at Codecov.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix #21698
💡 Background and solution
📝 Changelog
react@16.13.0.react@16.13.0会报警告的问题。☑️ Self Check before Merge