Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Menu.Item inline a tag display not correct #21699

Merged
merged 2 commits into from
Mar 2, 2020
Merged

fix: Menu.Item inline a tag display not correct #21699

merged 2 commits into from
Mar 2, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Feb 29, 2020 •
edited by afc163
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Resolve #21649

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu.Item a tag hidden bug.
🇨🇳 Chinese 修复 Menu.Item 中 a 标签换行无法显示的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 29, 2020 •
edited
Loading

@shaodahong shaodahong mentioned this pull request Feb 29, 2020
Closed
1 task
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 29, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9acda2b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 29, 2020 •
edited
Loading

Codecov Report

Merging #21699 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21699   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         305      305           
  Lines        6998     6998           
  Branches     1933     1933           
=======================================
  Hits         6850     6850           
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c64e4...9acda2b. Read the comment docs.

@afc163 afc163 merged commit 99e6fb9 into ant-design:master Mar 2, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 2, 2020
@shaodahong shaodahong deleted the fix-menu-item-inline-a-tag branch March 2, 2020 08:56
@zombieJ zombieJ mentioned this pull request Mar 4, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu.Item not show <a> tag inline text with Icon
3 participants
@shaodahong @ant-design-bot @afc163