Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark background in different container #21299

Merged
merged 30 commits into from
Feb 24, 2020
Merged

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Feb 9, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞 Fix the background of the components in the pop-up components in the dark theme. 💄 Optimization under the dark theme color swatches transparency. 🌟 new less variable @popover-customize-border-color, @list-customize-card-bg, @table-expand-icon-bg, @steps-background, @pagination-item-input-bg for theme customization.
🇨🇳 Chinese 🐞 修复暗色主题下,组件在弹出层组件下的背景样式问题。💄 优化暗色主题下色板透明度。🌟新增 less 变量 @popover-customize-border-color@list-customize-card-bg@table-expand-icon-bg@steps-background@pagination-item-input-bg 用于主题定制。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input/demo/group.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 9, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e73ec7:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #21299 into master will increase coverage by 0.07%.
The diff coverage is 98.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21299      +/-   ##
==========================================
+ Coverage   97.77%   97.84%   +0.07%     
==========================================
  Files         300      304       +4     
  Lines        7005     7018      +13     
  Branches     1932     1946      +14     
==========================================
+ Hits         6849     6867      +18     
+ Misses        156      151       -5
Impacted Files Coverage Δ
components/tree-select/index.tsx 97.72% <ø> (ø) ⬆️
components/form/index.tsx 100% <ø> (ø) ⬆️
components/form/FormItemInput.tsx 93.33% <ø> (ø) ⬆️
components/table/hooks/useLazyKVMap.ts 100% <100%> (ø) ⬆️
components/input/Input.tsx 100% <100%> (ø) ⬆️
components/descriptions/index.tsx 100% <100%> (+1.07%) ⬆️
components/form/FormItem.tsx 99% <100%> (-0.01%) ⬇️
components/notification/index.tsx 96.62% <100%> (+0.2%) ⬆️
components/typography/Editable.tsx 100% <100%> (ø) ⬆️
components/date-picker/locale/az_AZ.tsx 100% <100%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993cef9...9e73ec7. Read the comment docs.

@ycjcl868 ycjcl868 force-pushed the fix-dark-background branch 3 times, most recently from c0c7eaa to 543d8ca Compare February 12, 2020 00:17
@ycjcl868 ycjcl868 force-pushed the fix-dark-background branch from 6c03857 to 7395607 Compare February 14, 2020 09:48
@ycjcl868 ycjcl868 changed the title [WIP] fix: dark background in different container fix: dark background in different container Feb 14, 2020
@ycjcl868
Copy link
Contributor Author

/rebase

@ycjcl868 ycjcl868 merged commit c17b40a into master Feb 24, 2020
@ycjcl868 ycjcl868 deleted the fix-dark-background branch February 24, 2020 14:44
@pr-triage pr-triage bot added the PR: merged label Feb 24, 2020
@zombieJ zombieJ mentioned this pull request Feb 27, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants