fix: Replace NativeButtonProps with ButtonProps for okButtonProps and canc… #21165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
When trying to use the modal and pass a href to
okButtonProps
like so:TS will raise the error: "Object literal may only specify known properties, and 'href' does not exist in type 'NativeButtonProps'.ts(2322)"
This is because
okButtonProps
are defined as having the typeNativeButtonProps
;The
okButtonProps
are passed toActionButton
where they also had the typeNativeButtonProps
;Then they are passed to
Button
, in this caseButton
has the prop typePartial<AnchorButtonProps & NativeButtonProps>
;It seems that it would be correct to allow to change
NativeButtonProps
withButtonProps
since they also contain definitions in case an anchor props is desired.📝 Changelog
The changes are pretty straightforward,
NativeButtonProps
where replaced withButtonProps
inActionButton.tsx
andModal.tsx
.☑️ Self Check before Merge