Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timeline content style #21068

Merged
merged 1 commit into from
Jan 24, 2020
Merged

fix: timeline content style #21068

merged 1 commit into from
Jan 24, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jan 22, 2020 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21048

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Improved Timeline component style in RTL mode
🇨🇳 Chinese 完善 Timeline 组件 RTL 模式下样式

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Jan 22, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 22, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1a5e341:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #21068 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21068   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         296      296           
  Lines        6911     6911           
  Branches     1919     1918    -1     
=======================================
  Hits         6737     6737           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6f63f...1a5e341. Read the comment docs.

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 22, 2020

你的预览切换不了RTL，报错了。

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 22, 2020

image

像丢了一截，好奇怪。

@xrkffgg
Copy link
Member Author

xrkffgg commented Jan 22, 2020

我这边预览可以切换 RTL，没看到报错

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 22, 2020

可能是我缓存。

@afc163 afc163 merged commit f46b674 into ant-design:master Jan 24, 2020
@xrkffgg xrkffgg deleted the k-1 branch January 25, 2020 07:37
@zombieJ zombieJ mentioned this pull request Jan 27, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: timeline 组件 rtl 模式下展示问题
5 participants
@xrkffgg @ant-design-bot @yoyo837 @MrHeer @afc163