Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Table locale emptyText should work #21024

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fix: Table locale emptyText should work #21024

merged 1 commit into from
Jan 20, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 20, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21023

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table locale.emptyText not work issue.
🇨🇳 Chinese 修复 Table locale.emptyText 不生效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Jan 20, 2020
tests-checker[bot]
tests-checker bot suggested changes Jan 20, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 20, 2020 •
edited
Loading

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 445b28d:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jan 20, 2020 •
edited
Loading

Codecov Report

Merging #21024 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21024      +/-   ##
==========================================
+ Coverage   97.48%   97.48%   +<.01%     
==========================================
  Files         296      296              
  Lines        6909     6910       +1     
  Branches     1917     1871      -46     
==========================================
+ Hits         6735     6736       +1     
  Misses        174      174
Impacted Files Coverage Δ
components/table/Table.tsx 96.63% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5a3c6...445b28d. Read the comment docs.

@zombieJ zombieJ merged commit 9aee6d6 into master Jan 20, 2020
@zombieJ zombieJ deleted the table-locale branch January 20, 2020 07:12
@afc163 afc163 mentioned this pull request Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot override the emptyText in Table component
2 participants
@zombieJ @ant-design-bot