Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select 多选时的 padding #20861

Merged
merged 4 commits into from
Jan 13, 2020
Merged

fix: select 多选时的 padding #20861

merged 4 commits into from
Jan 13, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jan 13, 2020 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20850

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复select 组件单选、多选时的 padding

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Jan 13, 2020
@netlify
Copy link

netlify bot commented Jan 13, 2020 •
edited
Loading

Deploy preview for ant-design ready!

Built with commit 369d118

https://deploy-preview-20861--ant-design.netlify.com

@zombieJ zombieJ mentioned this pull request Jan 13, 2020
Closed
14 tasks
@zombieJ
Copy link
Member

zombieJ commented Jan 13, 2020

RTL 的也要改一下

@xrkffgg xrkffgg closed this Jan 13, 2020
@zombieJ zombieJ reopened this Jan 13, 2020
@zombieJ
Copy link
Member

zombieJ commented Jan 13, 2020

在你的 PR 继续改就行了

@xrkffgg
Copy link
Member Author

xrkffgg commented Jan 13, 2020

OK

@zombieJ
Copy link
Member

zombieJ commented Jan 13, 2020

RTL 的也要改一下

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 13, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 369d118:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #20850
antd reproduction template Issue #20850

@codecov
Copy link

codecov bot commented Jan 13, 2020 •
edited
Loading

Codecov Report

Merging #20861 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20861   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         296      296           
  Lines        6883     6883           
  Branches     1901     1865   -36     
=======================================
  Hits         6709     6709           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f470f3e...369d118. Read the comment docs.

xrkffgg
xrkffgg commented Jan 13, 2020
View reviewed changes
components/select/style/single.less Outdated
&.@{select-prefix-cls}-show-arrow .@{select-prefix-cls}-selection-search {
right: @input-padding-horizontal-sm + @font-size-base * 1.5;
}
// &.@{select-prefix-cls}-show-arrow .@{select-prefix-cls}-selection-search {
Copy link
Member Author

@xrkffgg xrkffgg Jan 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你可以看一下，当 RTL 模式时，单选的 padding 有些问题。我修改了一下。

其中这段代码我注销了，还是直接去掉？

@zombieJ

Copy link
Member Author

@xrkffgg xrkffgg Jan 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

外层的 ant-select-selection-search 有了left right 的设置

参照了一下input 的定义

感谢这里并不需要 padding-right 和 right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

觉得没用直接去掉即可

@yoyo837 yoyo837 requested a review from saeedrahimi January 13, 2020 08:26
@zombieJ
Copy link
Member

zombieJ commented Jan 13, 2020

截屏2020-01-13下午9 40 39

标题的 Select 塌了

@xrkffgg
Copy link
Member Author

xrkffgg commented Jan 13, 2020

😂😂我的锅

@zombieJ zombieJ merged commit 2c092df into ant-design:master Jan 13, 2020
@xrkffgg xrkffgg deleted the k branch January 14, 2020 01:00
@afc163
Copy link
Member

afc163 commented Jan 14, 2020 •
edited
Loading

commit message 和 PR 的标题都尽量写英文吧，这样 commits 里面看着统一一点。

@xrkffgg
Copy link
Member Author

xrkffgg commented Jan 14, 2020

commit message 和 PR 的标题都尽量写中文吧，这样 commits 里面看着统一一点。

你的意思是 英文吧

@afc163
Copy link
Member

afc163 commented Jan 14, 2020

对 😹

@afc163 afc163 mentioned this pull request Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ left review comments

@saeedrahimi saeedrahimi Awaiting requested review from saeedrahimi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4.x] Select/Input placeholder have different padding-left and color
3 participants
@xrkffgg @zombieJ @afc163