feat: add skeleton avatar #19898

Rustin170506 · 2019-11-22T14:26:47Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	add skeleton avatar
🇨🇳 Chinese	添加骨架头像

☑️ Self Check before Merge

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

View rendered components/skeleton/demo/avatar.md
View rendered components/skeleton/index.en-US.md
View rendered components/skeleton/index.zh-CN.md

tests-checker

Could you please add tests to make sure this change works as expected?

netlify · 2019-11-22T14:27:00Z

Deploy preview for ant-design ready!

Built with commit d842563

https://deploy-preview-19898--ant-design.netlify.com

codecov · 2019-11-22T14:35:16Z

Codecov Report

Merging #19898 into 4.0-prepare will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           4.0-prepare   #19898      +/-   ##
===============================================
+ Coverage        97.56%   97.56%   +<.01%     
===============================================
  Files              294      294              
  Lines             7227     7234       +7     
  Branches          2001     2001              
===============================================
+ Hits              7051     7058       +7     
  Misses             176      176

Impacted Files	Coverage Δ
components/skeleton/Button.tsx	`100% <ø> (ø)`	⬆️
components/skeleton/Element.tsx	`100% <ø> (ø)`
components/skeleton/Skeleton.tsx	`100% <100%> (ø)`	⬆️
components/skeleton/index.tsx	`100% <100%> (ø)`	⬆️
components/skeleton/Avatar.tsx	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76283f...d842563. Read the comment docs.

Rustin170506 · 2019-11-25T00:35:30Z

rebased.

Rustin170506 · 2019-11-26T06:55:16Z

ping~

codesandbox-ci · 2019-11-26T15:21:49Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d842563:

Sandbox	Source
antd reproduction template	Configuration

Rustin170506 · 2019-11-28T05:25:48Z

@afc163 @zombieJ PTAL~

components/skeleton/Button.tsx

components/skeleton/SkeletonParagraph.tsx

Rustin170506 · 2019-11-30T01:58:03Z

rebased.

zombieJ · 2019-11-30T03:57:55Z

https://deploy-preview-19898--ant-design.netlify.com/components/skeleton-cn/#components-skeleton-demo-avatar
https://deploy-preview-19898--ant-design.netlify.com/components/skeleton-cn/#components-skeleton-demo-button

These 2 example is similar. Could we merge them into one?

Rustin170506 · 2019-11-30T05:01:37Z

https://deploy-preview-19898--ant-design.netlify.com/components/skeleton-cn/#components-skeleton-demo-avatar
https://deploy-preview-19898--ant-design.netlify.com/components/skeleton-cn/#components-skeleton-demo-button

These 2 example is similar. Could we merge them into one?

merged.

Rustin170506 · 2019-12-01T05:00:44Z

CI test failed because calendar component.

Rustin170506 · 2019-12-02T00:18:56Z

rebased.

Rustin170506 · 2019-12-03T04:44:28Z

@zombieJ PTAL~

afc163 · 2019-12-03T05:25:09Z

Could you help to add a complete real world example of usage, include Skeleton, Skeleton.Button and Skeleton.Avatar.

Rustin170506 · 2019-12-03T05:29:10Z

Could you help to add a complete real world example of usage, include Skeleton, Skeleton.Button and Skeleton.Avatar.

I think I can do it, how about after I finished input and progress.

spencer741 · 2020-05-24T19:10:23Z

@Rustin-Liu The Skeleton component has the loading prop which can toggle visibility, but the loading prop doesn't work with Skeleton.Avatar.
<Skeleton.Avatar shape="square" size={125} loading={false}>
<Avatar shape="square" size={125} icon={<UserOutlined />} />
</Skeleton.Avatar>
Is this a misinterpretation of usage or a lack of functionality?

Rustin170506 · 2020-05-25T00:24:00Z

Is this a misinterpretation of usage or a lack of functionality?

Yes, this is a misinterpretation of usage. Because I think include a avatar into a skeleton avatar is weird. You can toggle it by yourself.

pr-triage bot added the PR: unreviewed label Nov 22, 2019

tests-checker bot suggested changes Nov 22, 2019

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Nov 22, 2019

Rustin170506 changed the title ~~Skeleton~~ feat: add skeleton avatar Nov 22, 2019

auto-add-label bot added the enhancement label Nov 22, 2019

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels Nov 22, 2019

weekly-digest bot mentioned this pull request Nov 24, 2019

Weekly Digest (17 November, 2019 - 24 November, 2019) #19909

Closed

zombieJ reviewed Nov 28, 2019

View reviewed changes

components/skeleton/Button.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Nov 28, 2019

View reviewed changes

components/skeleton/SkeletonParagraph.tsx Outdated Show resolved Hide resolved

Rustin170506 added 9 commits December 2, 2019 08:11

move avatar default props into skeleton

8547eb9

#18237 complete skeleton avatar

334f528

update skeleton avatar docs

ec6e0f2

add more tests for skeleton avatar

caf4172

refactor class and props name

1c6ceb0

revert Avatar props name

e147d90

combine avatar and button demo

e3898e0

update demo and test snapshots

1d09a44

move active props into element

d842563

afc163 merged commit 7a5fc8b into ant-design:4.0-prepare Dec 3, 2019

pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 3, 2019

weekly-digest bot mentioned this pull request Dec 8, 2019

Weekly Digest (1 December, 2019 - 8 December, 2019) #20136

Closed

hsuanxyz mentioned this pull request Dec 31, 2019

[Skeleton] support avatar & button & input properties NG-ZORRO/ng-zorro-antd#4619

Closed

Rustin170506 deleted the skeleton branch May 25, 2020 00:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add skeleton avatar #19898

feat: add skeleton avatar #19898

Rustin170506 commented Nov 22, 2019 •

edited by markdownify bot

Loading

tests-checker bot left a comment

netlify bot commented Nov 22, 2019 •

edited

Loading

codecov bot commented Nov 22, 2019 •

edited

Loading

Rustin170506 commented Nov 25, 2019

Rustin170506 commented Nov 26, 2019

codesandbox-ci bot commented Nov 26, 2019 •

edited

Loading

Rustin170506 commented Nov 28, 2019

Rustin170506 commented Nov 30, 2019

zombieJ commented Nov 30, 2019

Rustin170506 commented Nov 30, 2019

Rustin170506 commented Dec 1, 2019

Rustin170506 commented Dec 2, 2019

Rustin170506 commented Dec 3, 2019

afc163 commented Dec 3, 2019

Rustin170506 commented Dec 3, 2019

spencer741 commented May 24, 2020

Rustin170506 commented May 25, 2020

feat: add skeleton avatar #19898

feat: add skeleton avatar #19898

Conversation

Rustin170506 commented Nov 22, 2019 • edited by markdownify bot Loading

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

tests-checker bot left a comment

Choose a reason for hiding this comment

netlify bot commented Nov 22, 2019 • edited Loading

codecov bot commented Nov 22, 2019 • edited Loading

Codecov Report

Rustin170506 commented Nov 25, 2019

Rustin170506 commented Nov 26, 2019

codesandbox-ci bot commented Nov 26, 2019 • edited Loading

Rustin170506 commented Nov 28, 2019

Rustin170506 commented Nov 30, 2019

zombieJ commented Nov 30, 2019

Rustin170506 commented Nov 30, 2019

Rustin170506 commented Dec 1, 2019

Rustin170506 commented Dec 2, 2019

Rustin170506 commented Dec 3, 2019

afc163 commented Dec 3, 2019

Rustin170506 commented Dec 3, 2019

spencer741 commented May 24, 2020

Rustin170506 commented May 25, 2020

Rustin170506 commented Nov 22, 2019 •

edited by markdownify bot

Loading

netlify bot commented Nov 22, 2019 •

edited

Loading

codecov bot commented Nov 22, 2019 •

edited

Loading

codesandbox-ci bot commented Nov 26, 2019 •

edited

Loading