-
-
Notifications
You must be signed in to change notification settings - Fork 50.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Table #19678
Merged
Merged
New Table #19678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
afc163
reviewed
Nov 14, 2019
@shaodahong, Please help to check on this. Seems dropdown blink with new update on Firefox. Mini reproduce: const inputRef = React.createRef();
const menu = (
<div style={{ padding: 16, background: '#FFF', border: '1px solid red' }}>
<Input ref={inputRef} />
</div>
);
ReactDOM.render(
<Dropdown
overlay={menu}
trigger={['click']}
onVisibleChange={visible => {
if (visible) {
setTimeout(() => inputRef.current.select());
}
}}
>
<a className="ant-dropdown-link" href="#">
Click me <Down />
</a>
</Dropdown>,
mountNode,
); ref #19745 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
Preview
https://deploy-preview-19678--ant-design.netlify.com/components/table-cn/#header
View rendered components/table/demo/ajax.md
View rendered components/table/demo/bordered.md
View rendered components/table/demo/colspan-rowspan.md
View rendered components/table/demo/custom-filter-panel.md
View rendered components/table/demo/drag-sorting.md
View rendered components/table/demo/dynamic-settings.md
View rendered components/table/demo/edit-cell.md
View rendered components/table/demo/edit-row.md
View rendered components/table/demo/ellipsis.md
View rendered components/table/demo/expand-children.md
View rendered components/table/demo/expand.md
View rendered components/table/demo/fixed-columns-header.md
View rendered components/table/demo/fixed-columns.md
View rendered components/table/demo/fixed-header.md
View rendered components/table/demo/grouping-columns.md
View rendered components/table/demo/multiple-sorter.md
View rendered components/table/demo/nested-table.md
View rendered components/table/demo/reset-filter.md
View rendered components/table/demo/resizable-column.md