Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Table #19678

Merged
merged 63 commits into from
Nov 15, 2019
Merged

New Table #19678

merged 63 commits into from
Nov 15, 2019

Conversation

@pr-triage pr-triage bot added the PR: draft label Nov 11, 2019
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@zombieJ zombieJ marked this pull request as ready for review November 14, 2019 04:13
@pr-triage pr-triage bot removed the PR: draft label Nov 14, 2019
@zombieJ zombieJ changed the title [WIP] New Table New Table Nov 14, 2019
@afc163
Copy link
Member

afc163 commented Nov 14, 2019

image

在 Firefox 下没对齐。

@afc163
Copy link
Member

afc163 commented Nov 14, 2019

image

横向滚动在 Firefox 下看明确比 3.x 要卡顿。

@afc163
Copy link
Member

afc163 commented Nov 14, 2019

image

hover 到菜单时,图标背景高亮不会丢失。

@afc163
Copy link
Member

afc163 commented Nov 14, 2019

image

Blur 这个框时,消失的时候浮层会闪动,3.x 没有这个问题。

@zombieJ
Copy link
Member Author

zombieJ commented Nov 15, 2019

image

Blur 这个框时,消失的时候浮层会闪动,3.x 没有这个问题。

@shaodahong, Please help to check on this. Seems dropdown blink with new update on Firefox. Mini reproduce:

const inputRef = React.createRef();

const menu = (
  <div style={{ padding: 16, background: '#FFF', border: '1px solid red' }}>
    <Input ref={inputRef} />
  </div>
);

ReactDOM.render(
  <Dropdown
    overlay={menu}
    trigger={['click']}
    onVisibleChange={visible => {
      if (visible) {
        setTimeout(() => inputRef.current.select());
      }
    }}
  >
    <a className="ant-dropdown-link" href="#">
      Click me <Down />
    </a>
  </Dropdown>,
  mountNode,
);

ref #19745

@zombieJ
Copy link
Member Author

zombieJ commented Nov 15, 2019

@afc163
Copy link
Member

afc163 commented Nov 15, 2019

image

  • 发现这个 Demo 的编辑图标不见了。
  • 这个文案太难看懂了,应该是加载 ****** 条数据的高性能表格。

@zombieJ zombieJ merged commit 72a7ba6 into 4.0-prepare Nov 15, 2019
@zombieJ zombieJ deleted the 4.0-table branch November 15, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants