Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual select component #18658

Merged
merged 48 commits into from
Sep 12, 2019
Merged

Virtual select component #18658

merged 48 commits into from
Sep 12, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 4, 2019

Still working in progress!!!

Known issue

  • Animation in new react not correct
  • Test case should update

View rendered components/select/demo/custom-dropdown-menu.md
View rendered components/select/demo/debug.md
View rendered components/select/demo/search.md

@netlify
Copy link

netlify bot commented Sep 4, 2019

Deploy preview for ant-design ready!

Built with commit fd058d5

https://deploy-preview-18658--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Sep 4, 2019

File name Previous Size New Size Change
package-lock.json 851.97 KB 850.3 KB -1.67 KB (0%)

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #18658 into 4.0-prepare will decrease coverage by 0.02%.
The diff coverage is 96.51%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #18658      +/-   ##
===============================================
- Coverage        96.71%   96.69%   -0.03%     
===============================================
  Files              282      281       -1     
  Lines             7340     7320      -20     
  Branches          2033     2025       -8     
===============================================
- Hits              7099     7078      -21     
- Misses             239      240       +1     
  Partials             2        2
Impacted Files Coverage Δ
components/calendar/Header.tsx 96.84% <ø> (ø) ⬆️
components/pagination/MiniSelect.tsx 100% <100%> (ø) ⬆️
components/auto-complete/index.tsx 94.87% <94.59%> (-2.75%) ⬇️
components/select/index.tsx 98.14% <97.91%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8eac4c...fd058d5. Read the comment docs.

@zombieJ zombieJ changed the title [WIP] Virtual select component Virtual select component Sep 9, 2019
@zombieJ
Copy link
Member Author

zombieJ commented Sep 12, 2019

合了,免得 4.0-prepare | master 又冲突了。

@zombieJ zombieJ merged commit 2ea28af into 4.0-prepare Sep 12, 2019
@zombieJ zombieJ deleted the 4.0-select branch September 12, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants