Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker ref typing is wrong #31985

Closed
1 task done
acfasj opened this issue Aug 31, 2021 · 4 comments · Fixed by #31993
Closed
1 task done

DatePicker ref typing is wrong #31985

acfasj opened this issue Aug 31, 2021 · 4 comments · Fixed by #31993
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@acfasj
Copy link
Contributor

acfasj commented Aug 31, 2021 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://github.com/acfasj/antd-date-picker-ref-type

Steps to reproduce

  1. clone the repo and install deps git clone git@github.com:acfasj/antd-date-picker-ref-type.git && cd antd-date-picker-ref-type && yarn
  2. go to the src/App.tsx file
  3. assign a callback ref to ref attribute, the parameter of the callback called picker
  4. wanna get intellisense type hint like picker.focus() as document describes, but we got any type here

What is expected?

can get intellisense type hint on ref like picker.focus() as https://ant.design/components/date-picker/#Common-Methods describes

What is actually happening?

no type hint for ref instance methos

Environment Info
antd 4.16.13
React 17.0.2
System macOS Catalina 10.15.7
Browser chrome 86.0.4240.80（正式版本） (x86_64)
@afc163 afc163 added the 🤔 Need Reproduce We cannot reproduce your problem label Aug 31, 2021
@afc163
Copy link
Member

afc163 commented Aug 31, 2021

Your codesandbox is not a TypeScript project.

@github-actions
Copy link
Contributor

Hello @acfasj. Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro or a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 3 days.

你好 @acfasj, 我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击 此处 创建一个 codesandbox 或者提供一个最小化的 GitHub 仓库。3 天内未跟进此 issue 将会被自动关闭。

@acfasj
Copy link
Contributor Author

acfasj commented Aug 31, 2021

Your codesandbox is not a TypeScript project.

already provided the git repo and updated the issue.

however, the result is the same as codesandbox. although I dont know how codesandbox typescript projects work online, but it seems to be a valid typescript project

@afc163 afc163 added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. and removed 🤔 Need Reproduce We cannot reproduce your problem labels Sep 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Hello @acfasj. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @acfasj，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

giphy

@acfasj acfasj mentioned this issue Sep 1, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix DatePicker ref typing
2 participants
@afc163 @acfasj