Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onReset event to Form #29752

Merged
merged 1 commit into from
Mar 14, 2021
Merged

feat: add onReset event to Form #29752

merged 1 commit into from
Mar 14, 2021

Conversation

jueinin
Copy link
Contributor

@jueinin jueinin commented Mar 13, 2021 •
edited by yoyo837
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #29439
ref: react-component/field-form#278

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English button with htmlType='reset' will reset all form fileds
🇨🇳 Chinese form表单现在可以自动响应reset事件

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2021 •
edited
Loading

@jueinin jueinin changed the title update: update rc-field-form version feat: Form will respond to onReset event Mar 13, 2021
@jueinin jueinin changed the title feat: Form will respond to onReset event feat: add onReset event to Form Mar 13, 2021
@jueinin
Copy link
Contributor Author

jueinin commented Mar 13, 2021

这个检查就很奇怪，似乎是在说这个PR只有一个commit，但是就改一下版本号就行了啊，不需要啥commit

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 13, 2021 •
edited
Loading

是说你的commit的message写的不满足要求

@jueinin jueinin force-pushed the formOnReset branch 2 times, most recently from 72cd908 to 2c67599 Compare March 13, 2021 02:56
@jueinin
Copy link
Contributor Author

jueinin commented Mar 13, 2021

谢谢 已经修改

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 13, 2021

Conflicted!

@jueinin jueinin requested a review from zombieJ as a code owner March 13, 2021 03:08
@jueinin jueinin closed this Mar 13, 2021
@jueinin jueinin reopened this Mar 13, 2021
@codecov
Copy link

codecov bot commented Mar 13, 2021 •
edited
Loading

Codecov Report

Merging #29752 (cee25a1) into feature (37bff5d) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           feature    #29752      +/-   ##
============================================
+ Coverage    99.90%   100.00%   +0.09%     
============================================
  Files          394       394              
  Lines         7506      7506              
  Branches      2111      2111              
============================================
+ Hits          7499      7506       +7     
+ Misses           7         0       -7
Impacted Files Coverage Δ
components/carousel/index.tsx 100.00% <0.00%> (+17.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37bff5d...cee25a1. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Mar 13, 2021

文档、测试、TS 定义需要更新么？

@jueinin
Copy link
Contributor Author

jueinin commented Mar 13, 2021

应该不需要，因为我看button的type =submit就没写文档，有需要的话我可以把submit和reset的文档加上

@afc163 afc163 merged commit 1621802 into ant-design:feature Mar 14, 2021
@xrkffgg xrkffgg mentioned this pull request Mar 14, 2021
Merged
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jueinin @yoyo837 @afc163