-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add different width for different media for main content #473
Conversation
The changes are great, I was also thinking that a lot of space was "wasted" on the sides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I wouldn't be greedier though like @SMoraisAnsys mentioned 😄 you might start finding issues if you stick too much to the left side... 😄
|
||
@media (min-width: 960px) { | ||
.bd-page-width { | ||
max-width: min(100%, 1600px) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SMoraisAnsys, @RobPasMue increase this size to 1700px will increase the screen size, since 1920 is the standard resolution , i can increase this if you prefer (if you are greedy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result is great ! Is there a reason for the middle part to be that far away from the scroll bar ?
As far as I like this, I don't have enough hindsight to assess the extent to which this could cause problems (which @RobPasMue pointed out).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result is great ! Is there a reason for the middle part to be that far away from the scroll bar ? As far as I like this, I don't have enough hindsight to assess the extent to which this could cause problems (which @RobPasMue pointed out).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is going to far.... you probably dont want to have so much space between el central content and the right bar, and so little space between the central content and the scrollbar.....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The left and right content is having the same margin and padding, and the scroll bar appears only if there is an overflow in the content.
These are the 2 changes with and without scrollbar. pinging @mia-guo-ux also here for insights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinning me. When the text exceeds the container, I suggest truncating the text with "..." and show the full content upon hovering instead of enabling horizontal scrolling. The vertical scrollbar looks good to me. Also...I agree with the comments that balance is the key :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all, Then i will go with the above specifications, and about horizontal scrollbar, i will open another PR to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new change... but:
- Don't go too far with it, it will clutter the view.
- Don't stick too close to any of the sides while you have plenty of space on the other side. You want to strick a balance between both sides.
But overall, I like it. Great job!
src/ansys_sphinx_theme/theme/ansys_sphinx_theme/static/css/pydata-sphinx-theme-custom.css
Outdated
Show resolved
Hide resolved
…ata-sphinx-theme-custom.css
fix #325
Now
before