Add ansible-lint tooling added #813

ddimatos · 2023-06-15T19:51:22Z

SUMMARY

This addresses issue #809 partially. There is still the remaining CI/CD work to be done that is not managed in this repository. We can continue to track the CI/CD work for ansible-lint using this git issue #809 but can consider this issue complete for now.

ISSUE TYPE

Feature Pull Request

Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: ac galaxy.yml meta/runtime.yml Changes to be committed: new file: .ansible-lint new file: ac modified: galaxy.yml modified: meta/runtime.yml

Signed-off-by: ddimatos <dimatos@gmail.com>

ddimatos · 2023-06-15T20:11:07Z

No pipeline as there was no source module changes

ddimatos · 2023-06-16T19:43:47Z

There is no pipeline needed for this. @richp405 @ketankelkar

richp405

A missing intro line --- and a missing build_ignore.

.ansible-lint

galaxy.yml

Signed-off-by: ddimatos <dimatos@gmail.com>

ketankelkar

lgtm

* update zoau version checker and add unit testing Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Bugfix/769/1.6/zos copy does not overwrite permission on overwriten copy as comunity module (#790) * Change function behaivour, variables names and add test case to ensure result * Change test assertion to ensure wokrs as ansible module * Change test for the HSF * Add fragment * More readable test and better coments * add changelog fragment for zoau version checker bugfix (#800) Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Add ansible-lint tooling added (#813) * Add ansible-lint tooling Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: ac galaxy.yml meta/runtime.yml Changes to be committed: new file: .ansible-lint new file: ac modified: galaxy.yml modified: meta/runtime.yml * Changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Removing file brought it in by cherry pick Signed-off-by: ddimatos <dimatos@gmail.com> * Added missing keyword 'build_ignore' Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix for #807 - zos_copy ignores encoding for binary files (#810) * Updated normalization condition * Added test cases for bugfix * Added changelog fragment * Updated changelog fragment * Update zos_data_set member description created (#816) * Update zos_data_set module member description Signed-off-by: ddimatos <dimatos@gmail.com> * Adding fix for uncataloged vsam and non-vsam data sets Signed-off-by: ddimatos <dimatos@gmail.com> * Fixes the issue of parts of a vsam cluster remaining behind and allows user to correctly delete DS not in cat Signed-off-by: ddimatos <dimatos@gmail.com> * Update module doc to explain data set deltion for given volume Signed-off-by: ddimatos <dimatos@gmail.com> * Unbound local var fix Signed-off-by: ddimatos <dimatos@gmail.com> * Lint corrections Signed-off-by: ddimatos <dimatos@gmail.com> * remove unused imports Signed-off-by: ddimatos <dimatos@gmail.com> * Added 2.16 ignore since our pipeline supports devel which is at this time 2.16 Signed-off-by: ddimatos <dimatos@gmail.com> * Update module doc to explain data set deltion for given volumegit Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update grammar issue Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix: Fixes zos_copy and zos_fetch deprecation msg for using _play_context.verbosity (#814) * Add new test case for verbosity check Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_copy tests to support display.verbosity and nested encoding Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: deleted: tests/functional/modules/test_module_display.py modified: tests/functional/modules/test_zos_copy_func.py * Update test framewor to provide support for adhoc module calls Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_fetch plugin to use the display.verbosity Signed-off-by: ddimatos <dimatos@gmail.com> * Lint correction Signed-off-by: ddimatos <dimatos@gmail.com> * Update test with verbosity Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: modified: tests/functional/modules/test_zos_copy_func.py * Change from shell to raw module usage Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: modified: tests/functional/modules/test_zos_copy_func.py * changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment change Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Release tasks v1.6.0 (#829) * Galaxy for 1.6 Signed-off-by: ddimatos <dimatos@gmail.com> * Update ansible-core meta runtime Signed-off-by: ddimatos <dimatos@gmail.com> * Update collections private meta Signed-off-by: ddimatos <dimatos@gmail.com> * Missing trailing empty line Signed-off-by: ddimatos <dimatos@gmail.com> * Update readme with volume init info Signed-off-by: ddimatos <dimatos@gmail.com> * Update lint to match galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog summary Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog Signed-off-by: ddimatos <dimatos@gmail.com> * Minor manual CHANGELOG updates Signed-off-by: ddimatos <dimatos@gmail.com> * Relase notes updated Signed-off-by: ddimatos <dimatos@gmail.com> * Update build_ignore to skip importer_result.json Signed-off-by: ddimatos <dimatos@gmail.com> * update galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> * update galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up changelog fragements no longer need post releasing 1.6 Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com>

* Update branch production branch Main with release v1.5.0 content (#756) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Correct run on sentence Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added change fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * bring in updates to zos_gather_facts RETURN docstring (#744) Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests Signed-off-by: ddimatos <dimatos@gmail.com> * Update release notes and changelog with full date formats Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove changelog fragments no longer needed (#754) Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * v1.6.0-beta.1 release (#759) * Added tagging of converted files * Updated tests for zos_encode * Added restoration of PDS/PDSE members when module fails zos_copy can now track which members got overwritten or newly added to a partitioned data set, and restore them accordingly. This commit includes a refactorization of the copy_to_pdse method to simplify the restoration work. * Fixed cleanup of dest when module fails * Removed exception used for debugging * Added pytest markers * solved pep8 issue * Added more information to error when restoration fails * Update make file with new features to manage the nodes (#563) * Update make file with new features to manage the nodes Signed-off-by: ddimatos <dimatos@gmail.com> * Correct typo Signed-off-by: ddimatos <dimatos@gmail.com> * updated makefile to allow for no password in the clear and added a new host Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Fix a bug that failed to copy the cert to the managed node (#577) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Added apropiate error message in zos_lineinfile when src is not found * Better error message * Added fragment for changelog * Update git issue slection field (#593) * Update git issue slection field * Added some additional future versions * Added rule to ignore python 2.7 compile not supporting f strings * Corrected rule in ignore file * Update 584-zos_lineinfile-error-message.yml * Added missing fragments for issues 309 and 408 * update make file and related artifacts with recent zVM changes (#598) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Expand what is ingored for venv to all venv's (#613) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Ansible-core versions with updated ignore file pass (#615) * Validated that ansible-core versions with updated ignore file pass locally Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Update make file to read exported var VENV else default to 'venv' (#614) * Update make file to read exported var VENV else default to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Correct the default from defaultValue to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/558/zos copy backup dev (#609) * Create emergency backup only if force is set to False and dest exists * Added Changelog fragment * Updated imports ansible.module_utils._text to ansible.module_utils.common.text.converters (#602) * Updated import in zos_fetch * Updated import in zos_job_submit * Updated import in module_utils/data_set * Updated import in module_utils/System * Updated import in zos_copy * Updated import in zos_fetch * Added changelog fragment * Update enhancement-518-text-converter-import.yml * Updates the makefile and related scripts for the latest mounts (#628) * Update makefile coments and use --ignore for pytest Signed-off-by: ddimatos <dimatos@gmail.com> * lexicographical order targets Signed-off-by: ddimatos <dimatos@gmail.com> * Update makefile and artifacts to support new mounts Signed-off-by: ddimatos <dimatos@gmail.com> * Removing encrypted versions of the scripts, no longer senstive content Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * update profile created for mount points Signed-off-by: ddimatos <dimatos@gmail.com> * Correct f-string usage to remain 2.7 compatible (#659) * Correct f-string usage to remain 2.7 compatible Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Updated shell scripts for development tooling Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * changed zos_job_query to allow multi/embedded wildcard job_values. job.py/_get_job_status now uses fnmatch to test for wildcarded job_names. added test looking for a wildcard job name. added basic changelog text as 'enhancement'. * expanded wildcard support to job_id as well as job_name corrected error-handling issue in query routine playbook tests complete * cleaned up pep8 issues * Bug fix to correct job log returining and other edge cases (#683) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_job_submit.py Grammar change and correction. --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added uss_tag_encoding function * Fixing linter issues * removed extraneous comment on query, eliminated unused variable * responding to reviewer comments * Expanded query tests to run a hello jcl file to make sure we are searching for a job id that exists. * Expanded documentation in code to highlight asterisk availability. Added examples showing multi-asterisk search. * Corrected 2 documentation errors * Change to documentation text (indent on multi line string?) * Still trying to get documentation to pass * Looks like '---' was killing documentation block. * Update zos_blockinfile with complex examples (#727) * Update zos_blockinfile with complex examples Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional D SYMBOLS example to zos_operator documentation (#730) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * zos_gather_facts - add sample output to RETURN docstring (#722) * zos_gather_facts - add sample output to RETURN docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * zos_gather_facts RETURN docstring - add sample sysplex_name and lpar_name values Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update generated module doc Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * 574find (#668) * change to allow find loop to continue when one particular data set element is not found This has been validated with a zos-check-find.yaml playbook * added functional test that includes non-existant pds entry, which should be skipped over * added changelog fragment. * zos_blockinfile , can quotes in content can be supported (#680) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * A needed space * All in structured * Comments solved * Better order --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Demetri <dimatos@gmail.com> * zos_copy mode is applied to the destination directory, a deviation from the communtiy module behavior. (#723) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * Solve the dest functional mode set for the applied to destination directory * Identation and spaces * To work well * To work well * To work well * To work well * Changelogs added * Solved the fragment test and separte the cases --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * corrected job test case that wanted to extract job id. * changed call to zos_job_query in the functional test. * zos_data_set - add force parameter to enable member delete via disp shr (#718) * add force parameter to enable member delete via disp shr Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update link to PR instead of issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * fix minor mistake in func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update DOCstring for missed items highlighted in PR review Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years in data set module util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * update doc, rst Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Added handler for job not found edge cases (None not iterable errors) * corrected pep8 issue (bad indent) * removed tracking text from error/not found messages. * Update zos_job_query.py * Add and automate a load lib test case for module zos_copy (#640) * Modified if statement * Added changelog fragment * Corrected statements Corrected PR in changelog fix lint issue * Adding test case on the work * Added assertion to loadlib test Changed cobol src Added newlines * Correcting cobol src * Removed unnecessary comments * Removed deprint statements for debug * Update 601-copy-loadlib-member.yml * Reduce space primary * Make sure cobol is executable * corrected name * Corrected names * Adding debug statements * modified name in link step * Changing copy name * Removed print statements for debug * Removed previous changelog * Removed unused fragment * Removed test case * Add max_rc support for module zos_tso_command (#666) * rebuilding 565 * fixing pep8 issue * corrected not in code, added functional test to use maxrc * changing maxrc return codes as indicated * updated copy_rexx to incorporate max_rc * pep8 issue on an if statement * changed test to dump intermediate values temporarily * added max_rc to arg params to get it to pass through * removed extra output on test * Added changelog fragment. * Update 565-zos_tsocommand_maxrc.yml * PARTIAL correction based on reviewer's feedback. Will complete later today. * Partial push: change origrc to orig_rc and added documentation. Added experimental loop for multiline results. Changed error case to continue through the commands even after a failure (?!) * Changes based on review feedback: - rc is actual returned value - origrc/orig_rc removed - in a list of commands, first error (considering max_rc) stops the chain - while processing commands, a list of success/failures are kept for error state info - changed listds to a longer, more complete string in example * updated test case for max_rc to use longer, more complete listds command * Minor pep8 and yamllint changes * Updated string builder to use append and join, for efficiency. * Update changelog fragment to correspond to pull request number Signed-off-by: ddimatos <dimatos@gmail.com> * removed old fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changed output of command-by-command to use max_rc instead of Max RC, for consistency. * clarifying failure message when user hasn't set a max_rc. * corrected date on copyright notice to include current year. * corrected copyright date on test case --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> * added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * zos_copy forward port a test case for symbols on a volume #739 (#740) * added test case for symbols on a volume Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment added Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Volume Initialization Module (#654) * Adding ZOS_INIT plugins The module and action for ZOS_Init command, under zos_ickdsf_command. Designed for version 1.3.1, and example given references removed zos_ssh.py. * Create zos_ickdsf_command.rst Tentative documentation. Does not quite list every return, and program may change to work with overall zos core collection. * Update zos_ickdsf_command.py fixed to pass pep8 sanity test. * Update zos_ickdsf_command.py Edited zos_ickdsf_command.py in action folder to pass pep8 style check. * bugfix - undo hard-coded storagegroup param from command passed to mvs_raw Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update encoding and licensing info Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * edit descriptions, leaving in old to verify messaging with dfsms team Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to buildix Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * cleanup examples docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add return docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add some unit tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update dict names, some clean up Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update interface and docs with cleaner descriptions and define default values and required true/false where applicable Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove init param and bring out sub-options one level Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module from zos_ickdsf_command to zos_ickdsf_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove files referring to zos_ickdsf_command; i forgot to untrack these in the previous commit Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove params from intitial definition of results dict which are not always present, remove unused return params, rename message to msg to match ibm_zos_core and ansible style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add ignore missing gplv3 license warning from sanity testings to existing ignore files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * style edits to pass sanity tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add in-depth task name to first example docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add minimal params functional test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert action plugin to module_util, remove IckdsfCommand and CommandInit class definitions and custom error classes, move convert method to module_util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename rc param, update func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add note about disabled verify_offline check Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * removed volume_address checks which can be handled by ansiblemodule parsing validation or ickdsf itself; changed function signature of convert method to include results dicts so it can pass it to fail_json method in the case of module failure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add invalid volume_address func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * change param names, organize mvscmd return output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * consolidate negative func tests, add negative tests for vtoc_tracks param, start list for postive tests to implement Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func tests for "verify_existing_volid" and "verify_no_data_sets_exist" Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add volid positive and negative func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add mutual exclusion to no index/sms_managedw with func test, minor edits to comments * add func tests for index param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func test for vtoc_tracks param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove 'addr_range', 'volid_prefix' and 'output_html' params; add example with ansible loop to init multiple serial volumes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert 'content' return param to list for prettier playbook output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add specific examples to docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add guard rail test with volser check set to ensure target volume is as expected Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * switch target test vol to user02, remove existing data sets in initial test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * start adding author names to docstring, edits of yaml for sanity test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module to zos_volume_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove unit test suite which was not kept up to date with code restructure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove old/outdated .rst file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * bring up to speed with v1.5.0-beta.1 which is currently more recent than dev Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add sanity test 2.15 file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * clean up trailing empty lines/space chars Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * more pep8 style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * pull in more changes from latest dev branch Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * tweak tests/sanity/ignore-2.10.txt file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename volume_address to address, rename verify_no_data_sets_exist to verify_volume_empty, rename verify_existing_volid to verify_volid, rename vtoc_tracks to vtoc_size, rename return param command to cmd, make suggested doc changes, switch off check_mode Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * resolve pep8 line too long issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add year to copyright, add gh user name to author, restyle true/false with code rather than italics, remove backslashes in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update zos_fetch test case to create data set instead of using one that gets wiped away by zos_volume_init test cases Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * address PR comments including pep8 styling, docstring changes including add seealso section, add details around authorized usage of ickdsf, some light wordsmithing, and remove cmd from return structure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add backticks to other special chars in docs for consistency Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * on more formatting tweak to national chars in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add new param to support tmp_hlq Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * extend tmphlq binding to sysprint(*), disable verbose mode for mvscmd call Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to betterargparser - it cannot be used in its current state as it is too restrictive on volume serial and qualifier args Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove soft language ie beware, please; reduce line lengths, fix a spelling error Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * reorganize test case code for more logical grouping and un-nesting from a for loop, also update copyright year that was missed Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update display command check to only check particular lines instead of entire output in test_volid_address_assigned_correctly which would always be positive when tested against the entire output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> * Ported bugfixes for #664 and #678 from 1.5.0 (#743) * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Updated changelog fragment * Updated copyright information * Added comments to record length tests * Added more context to the record length normalization * Add force (disp=shr) option to zos_lineinfile and update zos_blockinfile with the same locking test case. (#731) * Add DISP=SHR by function force to the user * Add helper function for force cases only for EOF inserts * Test cases added * Just to check in the change case * All test cases for force in zos_lineinfile working properly * Test cases for force blockinfile * Fixes for style of code * One identation error * One identation error * One identation error * Documentation error * All test cases for line infile and block infile * Comments * Change the stdout to assert with expected of ds * Error of test case * Fragment added * Solve typo errors * Update to remove uncessary comment Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with force comments Signed-off-by: ddimatos <dimatos@gmail.com> * Solve some test problems * Copyright year * Copyright year * Add cases for other ecodes * Add test for all encodings * Cover all encodes test cases with force * Blockinfile force added for other encodes and DS types --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove duplicate function (#753) * Update branch production branch Main with release v1.5.0 content (#756) (#758) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always * Linting correction * Add changelog fragement for pr 683 * Clean up comments in code * Update restructured text for modules and changelog fragment * Add support to check for security exception to job submit module * Add additonal logic for jobs that use typerun=scan * Update chnagelog fragment * Correct run on sentence --------- * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example * Added change fragment --------- * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system * Add changelog fragment * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments --------- * bring in updates to zos_gather_facts RETURN docstring (#744) * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests * Update release notes and changelog with full date formats --------- * remove changelog fragments no longer needed (#754) --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * update galaxy and meta/ files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update rst doc files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add 1.6.0-beta.1 release summary fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * generate changelog Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add release notes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add additional stylizing Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Delete fragements once changelog is generated Signed-off-by: ddimatos <dimatos@gmail.com> * update stylizing around *none* in zos_volume_init docs Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernandofloresdev@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> * update zoau version checker and add unit testing Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Bugfix/769/1.6/zos copy does not overwrite permission on overwriten copy as comunity module (#790) * Change function behaivour, variables names and add test case to ensure result * Change test assertion to ensure wokrs as ansible module * Change test for the HSF * Add fragment * More readable test and better coments * add changelog fragment for zoau version checker bugfix (#800) Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Add ansible-lint tooling added (#813) * Add ansible-lint tooling Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: ac galaxy.yml meta/runtime.yml Changes to be committed: new file: .ansible-lint new file: ac modified: galaxy.yml modified: meta/runtime.yml * Changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Removing file brought it in by cherry pick Signed-off-by: ddimatos <dimatos@gmail.com> * Added missing keyword 'build_ignore' Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix for #807 - zos_copy ignores encoding for binary files (#810) * Updated normalization condition * Added test cases for bugfix * Added changelog fragment * Updated changelog fragment * Update zos_data_set member description created (#816) * Update zos_data_set module member description Signed-off-by: ddimatos <dimatos@gmail.com> * Adding fix for uncataloged vsam and non-vsam data sets Signed-off-by: ddimatos <dimatos@gmail.com> * Fixes the issue of parts of a vsam cluster remaining behind and allows user to correctly delete DS not in cat Signed-off-by: ddimatos <dimatos@gmail.com> * Update module doc to explain data set deltion for given volume Signed-off-by: ddimatos <dimatos@gmail.com> * Unbound local var fix Signed-off-by: ddimatos <dimatos@gmail.com> * Lint corrections Signed-off-by: ddimatos <dimatos@gmail.com> * remove unused imports Signed-off-by: ddimatos <dimatos@gmail.com> * Added 2.16 ignore since our pipeline supports devel which is at this time 2.16 Signed-off-by: ddimatos <dimatos@gmail.com> * Update module doc to explain data set deltion for given volumegit Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update grammar issue Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix: Fixes zos_copy and zos_fetch deprecation msg for using _play_context.verbosity (#814) * Add new test case for verbosity check Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_copy tests to support display.verbosity and nested encoding Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: deleted: tests/functional/modules/test_module_display.py modified: tests/functional/modules/test_zos_copy_func.py * Update test framewor to provide support for adhoc module calls Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_fetch plugin to use the display.verbosity Signed-off-by: ddimatos <dimatos@gmail.com> * Lint correction Signed-off-by: ddimatos <dimatos@gmail.com> * Update test with verbosity Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: modified: tests/functional/modules/test_zos_copy_func.py * Change from shell to raw module usage Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: modified: tests/functional/modules/test_zos_copy_func.py * changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment change Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Release tasks v1.6.0 (#829) * Galaxy for 1.6 Signed-off-by: ddimatos <dimatos@gmail.com> * Update ansible-core meta runtime Signed-off-by: ddimatos <dimatos@gmail.com> * Update collections private meta Signed-off-by: ddimatos <dimatos@gmail.com> * Missing trailing empty line Signed-off-by: ddimatos <dimatos@gmail.com> * Update readme with volume init info Signed-off-by: ddimatos <dimatos@gmail.com> * Update lint to match galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog summary Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog Signed-off-by: ddimatos <dimatos@gmail.com> * Minor manual CHANGELOG updates Signed-off-by: ddimatos <dimatos@gmail.com> * Relase notes updated Signed-off-by: ddimatos <dimatos@gmail.com> * Update build_ignore to skip importer_result.json Signed-off-by: ddimatos <dimatos@gmail.com> * update galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> * update galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up changelog fragements no longer need post releasing 1.6 Signed-off-by: ddimatos <dimatos@gmail.com> * delete older profile, not needed Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com>

* Added 2.16 ignore since our pipeline supports devel which is at this time 2.16 Signed-off-by: ddimatos <dimatos@gmail.com> * Change the line for the functional one (#805) * Add ansible-lint tooling added (#812) * Add ansible-lint tooling Signed-off-by: ddimatos <dimatos@gmail.com> * add changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * missing hyphen from command doc Signed-off-by: ddimatos <dimatos@gmail.com> * Update ac command with doc corrections Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * 439 addf (#821) * initial changes to support F format * adding F option, added basic test looking for failure during ensure-present * added print_results to a failing uncatalog test. * adding more preint_result statements to track down cataloging issue * removed other print statements, added one back (cataloging is just plain finicky) * corrected volume name on new test * removed extra print statement from test code. Added Changelog fragment. * Expanded test case to try 1 of each record format creation. Added mention of 'F' into the documentation of record_format in dataset.py * Bugfix/769/mode option does not behave the same way that it does in the community module (#795) * First suggestion * Add files to be overwriten to the files to be changed * Add functionality to test case to ensure behaivour * Add test case for keep behaivour * Delete test repetition * Delete test case from other branch * Change test cases to ensure works as ansible module * Add fragment and change variable names for clarity * Get better test case and comments * Restore test --------- Co-authored-by: Demetri <dimatos@gmail.com> * bugfix/823/Return destination attributes had hardcoded type and record format (#824) * Add solution * Add fragment * Bufix: Fixes zos_copy and zos_fetch deprecation msg for using _play_context.verbosity (#806) * Add new test case for verbosity check Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_copy tests to support display.verbosity and nested encoding Signed-off-by: ddimatos <dimatos@gmail.com> * Update test framewor to provide support for adhoc module calls Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_fetch plugin to use the display.verbosity Signed-off-by: ddimatos <dimatos@gmail.com> * Lint correction Signed-off-by: ddimatos <dimatos@gmail.com> * Changlog fragments Signed-off-by: ddimatos <dimatos@gmail.com> * Update test with verbosity Signed-off-by: ddimatos <dimatos@gmail.com> * Change from shell to raw module usage Signed-off-by: ddimatos <dimatos@gmail.com> * remove verbosity from test Signed-off-by: ddimatos <dimatos@gmail.com> * correct indentation Signed-off-by: ddimatos <dimatos@gmail.com> * update changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> * Stagging v1.6.0 merge into dev (#832) * Update branch production branch Main with release v1.5.0 content (#756) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Correct run on sentence Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added change fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * bring in updates to zos_gather_facts RETURN docstring (#744) Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests Signed-off-by: ddimatos <dimatos@gmail.com> * Update release notes and changelog with full date formats Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove changelog fragments no longer needed (#754) Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * v1.6.0-beta.1 release (#759) * Added tagging of converted files * Updated tests for zos_encode * Added restoration of PDS/PDSE members when module fails zos_copy can now track which members got overwritten or newly added to a partitioned data set, and restore them accordingly. This commit includes a refactorization of the copy_to_pdse method to simplify the restoration work. * Fixed cleanup of dest when module fails * Removed exception used for debugging * Added pytest markers * solved pep8 issue * Added more information to error when restoration fails * Update make file with new features to manage the nodes (#563) * Update make file with new features to manage the nodes Signed-off-by: ddimatos <dimatos@gmail.com> * Correct typo Signed-off-by: ddimatos <dimatos@gmail.com> * updated makefile to allow for no password in the clear and added a new host Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Fix a bug that failed to copy the cert to the managed node (#577) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Added apropiate error message in zos_lineinfile when src is not found * Better error message * Added fragment for changelog * Update git issue slection field (#593) * Update git issue slection field * Added some additional future versions * Added rule to ignore python 2.7 compile not supporting f strings * Corrected rule in ignore file * Update 584-zos_lineinfile-error-message.yml * Added missing fragments for issues 309 and 408 * update make file and related artifacts with recent zVM changes (#598) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Expand what is ingored for venv to all venv's (#613) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Ansible-core versions with updated ignore file pass (#615) * Validated that ansible-core versions with updated ignore file pass locally Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Update make file to read exported var VENV else default to 'venv' (#614) * Update make file to read exported var VENV else default to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Correct the default from defaultValue to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/558/zos copy backup dev (#609) * Create emergency backup only if force is set to False and dest exists * Added Changelog fragment * Updated imports ansible.module_utils._text to ansible.module_utils.common.text.converters (#602) * Updated import in zos_fetch * Updated import in zos_job_submit * Updated import in module_utils/data_set * Updated import in module_utils/System * Updated import in zos_copy * Updated import in zos_fetch * Added changelog fragment * Update enhancement-518-text-converter-import.yml * Updates the makefile and related scripts for the latest mounts (#628) * Update makefile coments and use --ignore for pytest Signed-off-by: ddimatos <dimatos@gmail.com> * lexicographical order targets Signed-off-by: ddimatos <dimatos@gmail.com> * Update makefile and artifacts to support new mounts Signed-off-by: ddimatos <dimatos@gmail.com> * Removing encrypted versions of the scripts, no longer senstive content Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * update profile created for mount points Signed-off-by: ddimatos <dimatos@gmail.com> * Correct f-string usage to remain 2.7 compatible (#659) * Correct f-string usage to remain 2.7 compatible Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Updated shell scripts for development tooling Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Update collab template Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Template updates Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * add udpated checkbox to collab template Signed-off-by: ddimatos <dimatos@gmail.com> * changed zos_job_query to allow multi/embedded wildcard job_values. job.py/_get_job_status now uses fnmatch to test for wildcarded job_names. added test looking for a wildcard job name. added basic changelog text as 'enhancement'. * expanded wildcard support to job_id as well as job_name corrected error-handling issue in query routine playbook tests complete * cleaned up pep8 issues * Bug fix to correct job log returining and other edge cases (#683) * Update zos_job_submit to handle some edge cases and return the job log nearly always Signed-off-by: ddimatos <dimatos@gmail.com> * Linting correction Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement for pr 683 Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up comments in code Signed-off-by: ddimatos <dimatos@gmail.com> * Update restructured text for modules and changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Add support to check for security exception to job submit module Signed-off-by: ddimatos <dimatos@gmail.com> * Add additonal logic for jobs that use typerun=scan Signed-off-by: ddimatos <dimatos@gmail.com> * Update chnagelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_job_submit.py Grammar change and correction. --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added uss_tag_encoding function * Fixing linter issues * removed extraneous comment on query, eliminated unused variable * responding to reviewer comments * Expanded query tests to run a hello jcl file to make sure we are searching for a job id that exists. * Expanded documentation in code to highlight asterisk availability. Added examples showing multi-asterisk search. * Corrected 2 documentation errors * Change to documentation text (indent on multi line string?) * Still trying to get documentation to pass * Looks like '---' was killing documentation block. * Update zos_blockinfile with complex examples (#727) * Update zos_blockinfile with complex examples Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Added additional D SYMBOLS example to zos_operator documentation (#730) * Update zos_operator with an additional example Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * zos_gather_facts - add sample output to RETURN docstring (#722) * zos_gather_facts - add sample output to RETURN docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * zos_gather_facts RETURN docstring - add sample sysplex_name and lpar_name values Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update generated module doc Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * 574find (#668) * change to allow find loop to continue when one particular data set element is not found This has been validated with a zos-check-find.yaml playbook * added functional test that includes non-existant pds entry, which should be skipped over * added changelog fragment. * zos_blockinfile , can quotes in content can be supported (#680) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * A needed space * All in structured * Comments solved * Better order --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Demetri <dimatos@gmail.com> * zos_copy mode is applied to the destination directory, a deviation from the communtiy module behavior. (#723) * Verify coomand of ZOAU support the doble quotes and get better output of message * Verify coomand of ZOAU support the doble quotes and get better output of message * Restore to the one tyme function solving TypeError * Test about cases with quotes supported * Solve comments * Comments in the changelog * Adjust test for working accord the text * Solve the dest functional mode set for the applied to destination directory * Identation and spaces * To work well * To work well * To work well * To work well * Changelogs added * Solved the fragment test and separte the cases --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * corrected job test case that wanted to extract job id. * changed call to zos_job_query in the functional test. * zos_data_set - add force parameter to enable member delete via disp shr (#718) * add force parameter to enable member delete via disp shr Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update link to PR instead of issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * fix minor mistake in func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update DOCstring for missed items highlighted in PR review Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years in data set module util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Update to doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * update doc, rst Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc and examples Signed-off-by: ddimatos <dimatos@gmail.com> * Added handler for job not found edge cases (None not iterable errors) * corrected pep8 issue (bad indent) * removed tracking text from error/not found messages. * Update zos_job_query.py * Add and automate a load lib test case for module zos_copy (#640) * Modified if statement * Added changelog fragment * Corrected statements Corrected PR in changelog fix lint issue * Adding test case on the work * Added assertion to loadlib test Changed cobol src Added newlines * Correcting cobol src * Removed unnecessary comments * Removed deprint statements for debug * Update 601-copy-loadlib-member.yml * Reduce space primary * Make sure cobol is executable * corrected name * Corrected names * Adding debug statements * modified name in link step * Changing copy name * Removed print statements for debug * Removed previous changelog * Removed unused fragment * Removed test case * Add max_rc support for module zos_tso_command (#666) * rebuilding 565 * fixing pep8 issue * corrected not in code, added functional test to use maxrc * changing maxrc return codes as indicated * updated copy_rexx to incorporate max_rc * pep8 issue on an if statement * changed test to dump intermediate values temporarily * added max_rc to arg params to get it to pass through * removed extra output on test * Added changelog fragment. * Update 565-zos_tsocommand_maxrc.yml * PARTIAL correction based on reviewer's feedback. Will complete later today. * Partial push: change origrc to orig_rc and added documentation. Added experimental loop for multiline results. Changed error case to continue through the commands even after a failure (?!) * Changes based on review feedback: - rc is actual returned value - origrc/orig_rc removed - in a list of commands, first error (considering max_rc) stops the chain - while processing commands, a list of success/failures are kept for error state info - changed listds to a longer, more complete string in example * updated test case for max_rc to use longer, more complete listds command * Minor pep8 and yamllint changes * Updated string builder to use append and join, for efficiency. * Update changelog fragment to correspond to pull request number Signed-off-by: ddimatos <dimatos@gmail.com> * removed old fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changed output of command-by-command to use max_rc instead of Max RC, for consistency. * clarifying failure message when user hasn't set a max_rc. * corrected date on copyright notice to include current year. * corrected copyright date on test case --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> * added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * zos_copy forward port a test case for symbols on a volume #739 (#740) * added test case for symbols on a volume Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment added Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with added comments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Volume Initialization Module (#654) * Adding ZOS_INIT plugins The module and action for ZOS_Init command, under zos_ickdsf_command. Designed for version 1.3.1, and example given references removed zos_ssh.py. * Create zos_ickdsf_command.rst Tentative documentation. Does not quite list every return, and program may change to work with overall zos core collection. * Update zos_ickdsf_command.py fixed to pass pep8 sanity test. * Update zos_ickdsf_command.py Edited zos_ickdsf_command.py in action folder to pass pep8 style check. * bugfix - undo hard-coded storagegroup param from command passed to mvs_raw Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update encoding and licensing info Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * edit descriptions, leaving in old to verify messaging with dfsms team Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to buildix Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * cleanup examples docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add return docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add some unit tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update dict names, some clean up Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update interface and docs with cleaner descriptions and define default values and required true/false where applicable Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove init param and bring out sub-options one level Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module from zos_ickdsf_command to zos_ickdsf_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove files referring to zos_ickdsf_command; i forgot to untrack these in the previous commit Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove params from intitial definition of results dict which are not always present, remove unused return params, rename message to msg to match ibm_zos_core and ansible style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add ignore missing gplv3 license warning from sanity testings to existing ignore files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * style edits to pass sanity tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add in-depth task name to first example docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add minimal params functional test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert action plugin to module_util, remove IckdsfCommand and CommandInit class definitions and custom error classes, move convert method to module_util Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename rc param, update func test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add note about disabled verify_offline check Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * removed volume_address checks which can be handled by ansiblemodule parsing validation or ickdsf itself; changed function signature of convert method to include results dicts so it can pass it to fail_json method in the case of module failure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add invalid volume_address func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * change param names, organize mvscmd return output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * consolidate negative func tests, add negative tests for vtoc_tracks param, start list for postive tests to implement Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func tests for "verify_existing_volid" and "verify_no_data_sets_exist" Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add volid positive and negative func tests Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add mutual exclusion to no index/sms_managedw with func test, minor edits to comments * add func tests for index param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add func test for vtoc_tracks param Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove 'addr_range', 'volid_prefix' and 'output_html' params; add example with ansible loop to init multiple serial volumes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * convert 'content' return param to list for prettier playbook output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add specific examples to docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add guard rail test with volser check set to ensure target volume is as expected Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * switch target test vol to user02, remove existing data sets in initial test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * start adding author names to docstring, edits of yaml for sanity test Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename module to zos_volume_init Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove unit test suite which was not kept up to date with code restructure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove old/outdated .rst file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * bring up to speed with v1.5.0-beta.1 which is currently more recent than dev Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add sanity test 2.15 file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * clean up trailing empty lines/space chars Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * more pep8 style Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * pull in more changes from latest dev branch Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * tweak tests/sanity/ignore-2.10.txt file Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * rename volume_address to address, rename verify_no_data_sets_exist to verify_volume_empty, rename verify_existing_volid to verify_volid, rename vtoc_tracks to vtoc_size, rename return param command to cmd, make suggested doc changes, switch off check_mode Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * resolve pep8 line too long issue Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add year to copyright, add gh user name to author, restyle true/false with code rather than italics, remove backslashes in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add changelog fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update zos_fetch test case to create data set instead of using one that gets wiped away by zos_volume_init test cases Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * address PR comments including pep8 styling, docstring changes including add seealso section, add details around authorized usage of ickdsf, some light wordsmithing, and remove cmd from return structure Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add backticks to other special chars in docs for consistency Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * on more formatting tweak to national chars in docstring Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add new param to support tmp_hlq Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * extend tmphlq binding to sysprint(*), disable verbose mode for mvscmd call Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove references to betterargparser - it cannot be used in its current state as it is too restrictive on volume serial and qualifier args Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * remove soft language ie beware, please; reduce line lengths, fix a spelling error Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * reorganize test case code for more logical grouping and un-nesting from a for loop, also update copyright year that was missed Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update display command check to only check particular lines instead of entire output in test_volid_address_assigned_correctly which would always be positive when tested against the entire output Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> * Ported bugfixes for #664 and #678 from 1.5.0 (#743) * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Updated changelog fragment * Updated copyright information * Added comments to record length tests * Added more context to the record length normalization * Add force (disp=shr) option to zos_lineinfile and update zos_blockinfile with the same locking test case. (#731) * Add DISP=SHR by function force to the user * Add helper function for force cases only for EOF inserts * Test cases added * Just to check in the change case * All test cases for force in zos_lineinfile working properly * Test cases for force blockinfile * Fixes for style of code * One identation error * One identation error * One identation error * Documentation error * All test cases for line infile and block infile * Comments * Change the stdout to assert with expected of ds * Error of test case * Fragment added * Solve typo errors * Update to remove uncessary comment Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with force comments Signed-off-by: ddimatos <dimatos@gmail.com> * Solve some test problems * Copyright year * Copyright year * Add cases for other ecodes * Add test for all encodings * Cover all encodes test cases with force * Blockinfile force added for other encodes and DS types --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * remove duplicate function (#753) * Update branch production branch Main with release v1.5.0 content (#756) (#758) * Bug fix to correct job log returining and other edge cases (#688) * Update zos_job_submit to handle some edge cases and return the job log nearly always * Linting correction * Add changelog fragement for pr 683 * Clean up comments in code * Update restructured text for modules and changelog fragment * Add support to check for security exception to job submit module * Add additonal logic for jobs that use typerun=scan * Update chnagelog fragment * Correct run on sentence --------- * Added additional `D SYMBOLS` example to zos_operator documentation (#729) * Update zos_operator with an additional example * Added change fragment --------- * Ported bugfixes for #664 and #678 * Updated file normalization for sequential datasets * Fixed encoding when a remote source is used * Added encoding normalization for record length (#664) This is a port and tweak from the normalization found in the L2 support branch. Now the normalization applies for both local and remote source files. There is still work left to validate how this behaves when copying to partitioned datasets, and see if the normalization needs to handle directories as well. * Refactored normalization for USS files * Updated line endings normalization in PDSEs * Updated create_temp_with_lf_endings * Added tests for line endings normalization * Added changelog fragment * Add copy lib member test case * Corrected changelog fragment * Add conflict resolution * Update 641-copy-loadlib-member.yml * zos_copy forward port a test case for symbols on a volume (#739) * Add a test case for symbols using an existing volume on our test system * Add changelog fragment * Update 739-zos_copy-volume-symbol-test.yml Update description to use symbols overs special chars. * Update test case with added comments --------- * bring in updates to zos_gather_facts RETURN docstring (#744) * Solve problem 619 about set mode on dest file (#746) * Solve problem 619 about set mode on dest file * Add fragment of 746 PR --------- * Merge release tasks for v1.5.0 into release branch (#752) * Updated metadata * Updated copyright information * Updated copyright in README * Generated changelog * Added previous versions to changelog * Changed a minor_change fragment to bugfix * Updated release notes * Update dependency finder to allow for all tests minus skip tests * Update release notes and changelog with full date formats --------- * remove changelog fragments no longer needed (#754) --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * update galaxy and meta/ files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update copyright years Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * update rst doc files Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add 1.6.0-beta.1 release summary fragment Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * generate changelog Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add release notes Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * add additional stylizing Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Delete fragements once changelog is generated Signed-off-by: ddimatos <dimatos@gmail.com> * update stylizing around *none* in zos_volume_init docs Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernandofloresdev@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> * update zoau version checker and add unit testing Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Bugfix/769/1.6/zos copy does not overwrite permission on overwriten copy as comunity module (#790) * Change function behaivour, variables names and add test case to ensure result * Change test assertion to ensure wokrs as ansible module * Change test for the HSF * Add fragment * More readable test and better coments * add changelog fragment for zoau version checker bugfix (#800) Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> * Add ansible-lint tooling added (#813) * Add ansible-lint tooling Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: ac galaxy.yml meta/runtime.yml Changes to be committed: new file: .ansible-lint new file: ac modified: galaxy.yml modified: meta/runtime.yml * Changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Removing file brought it in by cherry pick Signed-off-by: ddimatos <dimatos@gmail.com> * Added missing keyword 'build_ignore' Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix for #807 - zos_copy ignores encoding for binary files (#810) * Updated normalization condition * Added test cases for bugfix * Added changelog fragment * Updated changelog fragment * Update zos_data_set member description created (#816) * Update zos_data_set module member description Signed-off-by: ddimatos <dimatos@gmail.com> * Adding fix for uncataloged vsam and non-vsam data sets Signed-off-by: ddimatos <dimatos@gmail.com> * Fixes the issue of parts of a vsam cluster remaining behind and allows user to correctly delete DS not in cat Signed-off-by: ddimatos <dimatos@gmail.com> * Update module doc to explain data set deltion for given volume Signed-off-by: ddimatos <dimatos@gmail.com> * Unbound local var fix Signed-off-by: ddimatos <dimatos@gmail.com> * Lint corrections Signed-off-by: ddimatos <dimatos@gmail.com> * remove unused imports Signed-off-by: ddimatos <dimatos@gmail.com> * Added 2.16 ignore since our pipeline supports devel which is at this time 2.16 Signed-off-by: ddimatos <dimatos@gmail.com> * Update module doc to explain data set deltion for given volumegit Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Update grammar issue Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix: Fixes zos_copy and zos_fetch deprecation msg for using _play_context.verbosity (#814) * Add new test case for verbosity check Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_copy tests to support display.verbosity and nested encoding Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: deleted: tests/functional/modules/test_module_display.py modified: tests/functional/modules/test_zos_copy_func.py * Update test framewor to provide support for adhoc module calls Signed-off-by: ddimatos <dimatos@gmail.com> * Update zos_fetch plugin to use the display.verbosity Signed-off-by: ddimatos <dimatos@gmail.com> * Lint correction Signed-off-by: ddimatos <dimatos@gmail.com> * Update test with verbosity Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: modified: tests/functional/modules/test_zos_copy_func.py * Change from shell to raw module usage Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: tests/functional/modules/test_zos_copy_func.py Changes to be committed: modified: tests/functional/modules/test_zos_copy_func.py * changelog fragment Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment change Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Release tasks v1.6.0 (#829) * Galaxy for 1.6 Signed-off-by: ddimatos <dimatos@gmail.com> * Update ansible-core meta runtime Signed-off-by: ddimatos <dimatos@gmail.com> * Update collections private meta Signed-off-by: ddimatos <dimatos@gmail.com> * Missing trailing empty line Signed-off-by: ddimatos <dimatos@gmail.com> * Update readme with volume init info Signed-off-by: ddimatos <dimatos@gmail.com> * Update lint to match galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog summary Signed-off-by: ddimatos <dimatos@gmail.com> * Added changelog Signed-off-by: ddimatos <dimatos@gmail.com> * Minor manual CHANGELOG updates Signed-off-by: ddimatos <dimatos@gmail.com> * Relase notes updated Signed-off-by: ddimatos <dimatos@gmail.com> * Update build_ignore to skip importer_result.json Signed-off-by: ddimatos <dimatos@gmail.com> * update galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> * update galaxy build_ignore Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Clean up changelog fragements no longer need post releasing 1.6 Signed-off-by: ddimatos <dimatos@gmail.com> * delete older profile, not needed Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Fernando Flores <fernandofloresdev@gmail.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: ketankelkar <ktnklkr@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: trevor-glassey <Trevor.Glassey@ibm.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@mbp-de-andre-2.gdl.mex.ibm.com> * Bug fix, zos_copy returns an error message when a concurrent copy fails (#794) * Test case to validate bug does not happen * First iteration for solutions * First proposal to validate_disposition * Remove unecesary test * Solvin unecesary code * Cover all cases with bug or false positive * Add test case to ensure behaviour * Get the better version of test case * Add fragment * Solve identation * Solve identation * Solve identation * Solve error in cleanup folders * Change function name * Change variables names * Solve wrote and write * Update changelog entry Signed-off-by: ddimatos <dimatos@gmail.com> * Better verbose and function name * Better message * Solve certification tests * Clearer and eficient version * continuation line over-indented solve * continuation line over-indented solve --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Enhancement/428/jinja2 template support (#667) * Added Jinja2 support for single files in zos_copy * Fixed cleanup of rendered templates * Added templating for directories * Fixed encoding conversion for directories (#616) While working on adding Jinja2 support for directories, I noticed that files that were in subdirectories would show garbage in a shell, which reminded me of issue #616. After implementing their suggestion, files now show the rendered templates. * Disabled rendering for remote sources * Enhanced exception handling for templates * Added encoding normalization for templates * Added templating tests to zos_copy * Added templating support to zos_job_submit * Fixed missing newline * Added failure when using templates with remote sources * Fixed encoding normalization * Fixed sanity tests issues * Added Jinja2 tests to zos_job_submit * Updated template test for zos_job_submit * Fixed template environment creation * Refactored template environment creation * Fixed initial size computation for local files * Fixed merge mistakes * Updated description for trim_blocks * Updated docs * Added test for Jinja2 loops * Added changelog fragment * Removed duplicated function * Changed try-except blocks used in action plugins * Updated template docs with variable precedence * Changed dictionary update in action plugin * Added another encoding for template tests * Fixed import errors in template.py * Fixed import error in Python 2.7 * Fixed bandit issue * Fixed template cleanup * Updated documentation --------- Co-authored-by: Demetri <dimatos@gmail.com> * Module zos_unarchive & zos_archive (#755) * Initial commit * Created template for zos_unarchive * Initial boiler plate for unarchive * Added unarchive handler selection * Added file/data set search * Adding AMATERSE unpacking * Added support for terse unarchive * Remove zos_archive module from the branch * Adding RECEIVE/XMIT support * Added temporary dataset removal * Adding RECEIVE as an mvscmd * Add RECEIVE using mvs_cmd * Add unpacked datasets display * Added display of unpacked targets support for multiple data sets * Added alias to options * Added include/ exclude options * Added include for xmit and terse * Modified include for all * Adding volume selection for SMS managed * Added list support for MVS archives * Removed unused var * Add force support for mvs data sets * Add archive listing for tar, bz2, and gz * Add unarchive all for tar, gz and bz2 * Added include/exclude support for tar, gz, bz2 * Add mvs_cmd amaterse * Modify mvs_cmd call * Add archive.py * Add latest zos_archive * Refactor mvs_cmd * Remove comments * Adding tests for zos_archive * Added unzip * Added arcroot logic and tarfile * Added changed logic * lastest changes * Multiple changes to zos_archive and zos_unarchive and its tests * Added support for pax * added list tests * Created action plugin for zos_unarchive * Add support for remove * Adding tests for exclusion list USS * Added tests * Add dest_data_set info * Adding multiple test cases and updated docs * Added test for mode * Removed unused stuff * Modified XMIT command * Added expanded paths support for mvs data sets * Added ugly multiple data set tests * Added various new tests for mvs data sets * Added new tests and default dest data set * Added default dest data set * Fixed pep8 issues * Added docs * Added docs * Fixed various sanity issues * removed abc.ABC * Added filters * modified fdict * polish test cases * Added tests * Added record length change * Fixed record length error * fix pylint issue * Add env cleaning in when terse or xmit fails * Moved locking tests below * Added tests for multiple data set in unarchive and modified test archive and unarchive names * Added tests for zos_unarchive * Added replace into zos_data_set invocation * Added replace * Added docs * Added * Added docs * Cleaned docs * Added permission change in zos_unarchive * Added mode support for USS files * Added is_binary option * Added zos_archive and zos_unarchive rst * Updated docs * Updated docs * Updated docs * Removed debug statements * fix pylint issues * Added get restored data sets * Removed replace flag * Added lock process removal * Removed print statements and blank lines * Removed print statements * Removed unused imports * added missing test * Completed uncompleted doc string * Fixed a bug that removed the source when not needed * Fixed pep8 issue * Added removal in correct place * fixed a bug that left behind tmp data sets * Added changes for deleting tmp data sets + pr code review comments * Added a notes and seealso section in the docs * Changed name to xmit_log_data_set * Added comments * Added comments about format * Added more description in terse_pack * Added mode description * Added description for tmp_hlq * Added description for remove * Added 'a' into some statements * Modified dest_state description * Updated option descriptions * Changed badzip error msg * changed adrdssu multiple data set error message * Added tso xmit error message * changed adrdssu multiple data set error message * modified description msg * Updated path to src and changed multiple docs * Fixed module doc issues * Removed unused error and modified error messages * Changed parameter result get * Updated docs in zos_unarchive * Updates docs * Updated docs * Modified mode * Changed src in action * Updated include docs * Updated include docs * Updated docs * Enhanced is_binary support * Fixed dest_data_set issue * Changed docs * Added changes to compute space primary * Added changes to compute space primary * Changed binary test case * Updated docs and test cases * Added xmit_log_data_set docs * Modified dest description * Updated docs * Updated docs * Updated docs * Updated docs * Updated docs * Updated docs * Updated docs * Updated docs * Updaded expanded sources * Updated docs * Updated docs * Updated docs * Updated docs and added dest_data_set * Added dest_data_set * Added primary_space * Fixed pep8 * updated dest_volumes comments * added xmit_log_data_set docs * Updated docs about mode * Added is binary comment * Removed is_binary * Removed is_binary from source * Updated targets list * Updated force docs * Updated the force docs * Updated exclude docs * Updated message for dest in zos_archive * Changed dest to required: true * Removed exclusion_patterns * Updated group in zos_archive * Corrected mode * Updated wording in owner * Updated src * Updated docs * Updated template * Fixed sanity issues * Updated PDS/PDSE to mayus * fixed mem creation * Fixed space type issue * Modifed test for des_data_set * fixed test * Improved dest_data_set * updated docs * updated dest_data_set type * Added latest docs * Removed emergency backup and auto-recovery features. (#896) * Removed emergency backup and auto-recovery features. Initial changelog fragment. * corrected changelog with PR # * Update changelog fragement Signed-off-by: ddimatos <dimatos@gmail.com> * removed 2 unused routines: restore_backup and erase_backup. --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Enhance/839/add field to job query (#841) * Initial change to manage 1.2.4 column changes for job listing * Improved documentation, code validated with playbooks. * Updated changelog fragment with PR * corrected duplicate entry in output documentation * Changes to comments and field names as per PR 841 Update to in-code documentation Expansion of changelog fragment * correction to datetime processing * fixing sample data * Enhancement/850/Redesining test cases to be clearer (#840) * Remove duplicates and unnecesary declaration from lineinfile test * Delete blockninfile repeat and unecesary cases and finishing lineinfile * Solve test do not pass * Summary USS test case lineinfile * Clean ds tests general * Finishing clear lineinfile * Lineinfile clean proposal * Clean lineinfile * Finishing the clean of lineinfile and blockinfile * Lineinfile USS fully cleaned * Lineinfile clean * Clean blocinfile test * Structure for all test cases * Add fragment * Finall version without dictionaries * Add expected to variables encoding test case and simplify names * Close lineinfile * Remove the unnecesary marks * Get better encoding tests * Get better encoding tests * Remove encodings of datasets * Add encoding for ds * Functional tso command test cases currently can not be run concurrently#880 (#895) * Remove all dependent test and summary in one * Add fragment * Solve multiple commands and text about the explanation of testing * Change variables to be accurate * Remove import do not used * Add comments * Solve typos and writting --------- Co-authored-by: ketankelkar <ktnklkr@gmail.com> * Update make file doc generation with pre and post scripts for a subset of modules. (#906) * Update make file and add scripts to correct doc gen Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc with missing definition of timestamp Signed-off-by: ddimatos <dimatos@gmail.com> * Correct doc to remove colon to prevent doc gen warning Signed-off-by: ddimatos <dimatos@gmail.com> * Update doc base on minor module doc changes Signed-off-by: ddimatos <dimatos@gmail.com> * Add changelog Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Enhance/911/Improve-job-query-performance (#911) * Initial change to manage 1.2.4 column changes for job listing * Improved documentation, code validated with playbooks. * Updated changelog fragment with PR * corrected duplicate entry in output documentation * Changes to comments and field names as per PR 841 Update to in-code documentation Expansion of changelog fragment * correction to datetime processing * fixing sample data * changed job to pass column options to disable the program_name column tested against fresh zoau build (881) * removed 'testing' comment * updated re-request call to use the kwargs function. note: this is for record-keeping... about to rebuild this section * Modified call chain in job:status to not pull dd's, making it faster added new 'don't get dd' variable in get_job_output internal * corrected pep8 issues (spaces and parentheses) * Addressing requested changes: eliminate double negative Added new changelog fragment, corrected link to PR Updated return documentation to show dependancy on zoau version * Correct grammar in changelog Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update Readme with new collection content Signed-off-by: ddimatos <dimatos@gmail.com> * Update copyright yrs Signed-off-by: ddimatos <dimatos@gmail.com> * Generated doc updates Signed-off-by: ddimatos <dimatos@gmail.com> * Update module doc to clear the boolean value comes back as 1 or 0 Signed-off-by: ddimatos <dimatos@gmail.com> * Move a fragment that was outside the changlog folder Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog fragment lint error corrections and summary added Signed-off-by: ddimatos <dimatos@gmail.com> * Changelog generated Signed-off-by: ddimatos <dimatos@gmail.com> * release notes Signed-off-by: ddimatos <dimatos@gmail.com> * Delete changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> * Update test with string match Signed-off-by: ddimatos <dimatos@gmail.com> * Unused changed variable, found by flake8 Signed-off-by: ddimatos <dimatos@gmail.com> * Unused 'normalize_line_endings' functiion found by flake8 Signed-off-by: ddimatos <dimatos@gmail.com> * Correct flake8, import 'path' from line 18 shadowed by loop variable Signed-off-by: ddimatos <dimatos@gmail.com> * Correct comment starting at a new line Signed-off-by: ddimatos <dimatos@gmail.com> * Updated new script copyright year Signed-off-by: ddimatos <dimatos@gmail.com> * Fix release notes formatting Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/583/zos lineinfile does not behave community (#916) * First iteration * Clean test apf_func * Add test case to validate change in ZOAU 1.2.4 * Change test case for the new change * Change zos_job_query test accord to ZOAU 1.2.4 * Restore test as dev * Return test to originals * Return job_query as original * Add fragment * Add test case for DS and change fragments * Solve check of testing for DS * Change logic of tests * Deprecate debug=true in zos_blockinfile and set as_json=true (#904) * Change debug for as_json option * Add fragment --------- Co-authored-by: ketankelkar <ktnklkr@gmail.com> * Add test case to validate response come back complete (#918) * Add test case to validate response come back complete * Add fragment --------- Co-authored-by: ketankelkar <ktnklkr@gmail.com> * Remove conditional unnecessary (#934) * Remove conditional unecesary * Add fragment * Correct the conditional * v1.7.0 beta.2 into dev (#953) * Staging v1.7.0 beta.1 (#915) * Added tagging of converted files * Updated tests for zos_encode * Added restoration of PDS/PDSE members when module fails zos_copy can now track which members got overwritten or newly added to a partitioned data set, and restore them accordingly. This commit includes a refactorization of the copy_to_pdse method to simplify the restoration work. * Fixed cleanup of dest when module fails * Removed exception used for debugging * Added pytest markers * solved pep8 issue * Added more information to error when restoration fails * Update make file with new features to manage the nodes (#563) * Update make file with new features to manage the nodes Signed-off-by: ddimatos <dimatos@gmail.com> * Correct typo Signed-off-by: ddimatos <dimatos@gmail.com> * updated makefile to allow for no password in the clear and added a new host Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Fix a bug that failed to copy the cert to the managed node (#577) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Added apropiate error message in zos_lineinfile when src is not found * Better error message * Added fragment for changelog * Update git issue slection field (#593) * Update git issue slection field * Added some additional future versions * Added rule to ignore python 2.7 compile not supporting f strings * Corrected rule in ignore file * Update 584-zos_lineinfile-error-message.yml * Added missing fragments for issues 309 and 408 * update make file and related artifacts with recent zVM changes (#598) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Expand what is ingored for venv to all venv's (#613) Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Ansible-core versions with updated ignore file pass (#615) * Validated that ansible-core versions with updated ignore file pass locally Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> * remove redundant entry on last line Signed-off-by: ddimatos <dimatos@gmail.com> Signed-off-by: ddimatos <dimatos@gmail.com> * Update make file to read exported var VENV else default to 'venv' (#614) * Update make file to read exported var VENV else default to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Correct the default from defaultValue to 'venv' Signed-off-by: ddimatos <dimatos@gmail.com> * Bugfix/558/zos copy backup dev (#609) * Create emergency backup only if force is set to False and dest exists * Added Changelog fragment * Updated imports ansible.module_utils._text to ansible.module_utils.common.text.converters (#602) * Updated import in zos_fetch * Updated import in zos_job_submit * Updated import in module_utils/data_set * Updated import in module_utils/System * Updated import in zos_copy * Updated import in zos_fetch * Added changelog fragment * Update enhancement-518-text-converter-import.yml * Updates the makefile and related scripts for the latest mounts (#628) * Update makefile coments and use --ignore for pytest Signed-off-by: ddimatos <dimatos@gmail.com> * lexicographical order targets Signed-off-by: ddimatos <dimatos@gmail.com> * Update makefile and artifacts to support new mounts Signed-off-by: ddimatos <dimatos@gmail.com> * Removing encrypted versions of the scripts, no longer senstive content Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * update profile created for mount points Signed-off-by: ddimatos <dimatos@gmail.com> * Correct f-string usage to remain 2.7 compatible (#659) * Correct f-string usage to remain 2.7 compatible Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments Signed-off-by: ddimatos <dimatos@gmail.com> --------- Signed-off-by: ddimatos <dimatos@gmail.com> * Updated shell scripts for development tooling Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> * Add issue template updates Signed-off-by: ddimatos <dimatos@gmail.com> *…

ddimatos added 2 commits June 15, 2023 12:48

Add ansible-lint tooling

e1fc39e

Signed-off-by: ddimatos <dimatos@gmail.com> Conflicts: ac galaxy.yml meta/runtime.yml Changes to be committed: new file: .ansible-lint new file: ac modified: galaxy.yml modified: meta/runtime.yml

Changelog fragment

11eb6fb

Signed-off-by: ddimatos <dimatos@gmail.com>

ddimatos changed the title ~~Udpate/809/ansilbe lint enablement for 1.6.0~~ Add ansible-lint tooling added Jun 15, 2023

ddimatos changed the base branch from dev to stagging-v1.6.0 June 15, 2023 20:05

Removing file brought it in by cherry pick

cb820bc

Signed-off-by: ddimatos <dimatos@gmail.com>

ddimatos requested review from richp405 and ketankelkar June 15, 2023 20:10

ddimatos self-assigned this Jun 15, 2023

ddimatos added the Waiting on Reviewers label Jun 15, 2023

ddimatos marked this pull request as ready for review June 16, 2023 04:48

ddimatos added Waiting on Reviewers and removed Waiting on Reviewers labels Jun 16, 2023

richp405 requested changes Jun 16, 2023

View reviewed changes

.ansible-lint Show resolved Hide resolved

galaxy.yml Show resolved Hide resolved

Added missing keyword 'build_ignore'

d9001f3

Signed-off-by: ddimatos <dimatos@gmail.com>

richp405 approved these changes Jun 16, 2023

View reviewed changes

ketankelkar approved these changes Jun 16, 2023

View reviewed changes

ddimatos merged commit 7da34d9 into stagging-v1.6.0 Jun 16, 2023

ddimatos deleted the udpate/809/ansilbe-lint-enablement-for-1.6.0 branch June 16, 2023 20:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ansible-lint tooling added #813

Add ansible-lint tooling added #813

ddimatos commented Jun 15, 2023 •

edited

Loading

ddimatos commented Jun 15, 2023

ddimatos commented Jun 16, 2023

richp405 left a comment

ketankelkar left a comment

Add ansible-lint tooling added #813

Add ansible-lint tooling added #813

Conversation

ddimatos commented Jun 15, 2023 • edited Loading

SUMMARY

ISSUE TYPE

ddimatos commented Jun 15, 2023

ddimatos commented Jun 16, 2023

richp405 left a comment

Choose a reason for hiding this comment

ketankelkar left a comment

Choose a reason for hiding this comment

ddimatos commented Jun 15, 2023 •

edited

Loading