-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meta data and docs for 1.5.0-beta.1 release tasks #650
Update meta data and docs for 1.5.0-beta.1 release tasks #650
Conversation
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.rst
- line 49, add a space after the dash
- line 70 - fixed should be fixes , also capitalize F
- line 76 - capitalize f in fixes
changelogs/changelog.yml
- line 388 - fixed should be fixes , also capitalize F
- line 407 - capitalize f in fixes
- line 409 - consider removing word ‘this’ and start sentence with “Also cleans up…”
- line 581 - 588-zos_copy-emergenxy-backup.yml should be emergency not emergenxy
for meta/runtime.yml
- are we still supoorting 2.9? should ansible-core version be bumped up?
Thanks @ketankelkar , ill make the edits although not keen on editing what was generated, those files you reference are generated based on our changelog fragments, this is why I commented when we get to the point they are where we like them to be we can drop the release_notes.rst, changelog fragments are a what feeds the tooling so spelling and other errors will come through. As for 2.9 , yes we are still supporting 2.9 through September 29th 2023, we support it till AAP 1.2 goes out of service. |
Also note I did not put a limit on the ansible version this time around because it will allow users to easily try the dev branch (ansible-core 2.15) , when we GA to Hub we can determine the upper bound at that time of what is required by RH. |
Most the edits are in place, I can't change |
Signed-off-by: ddimatos <dimatos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
SUMMARY
Addresses #390 , #630 , #649 , #651
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION