Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta data and docs for 1.5.0-beta.1 release tasks #650

Merged
merged 8 commits into from
Feb 22, 2023

Conversation

ddimatos
Copy link
Collaborator

@ddimatos ddimatos commented Feb 22, 2023

SUMMARY

Addresses #390 , #630 , #649 , #651

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos ddimatos changed the base branch from dev to release-v1.5.0-beta.1 February 22, 2023 07:21
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos ddimatos requested a review from ketankelkar February 22, 2023 22:33
@ddimatos ddimatos marked this pull request as ready for review February 22, 2023 22:33
Copy link
Collaborator

@ketankelkar ketankelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.rst

  • line 49, add a space after the dash
  • line 70 - fixed should be fixes , also capitalize F
  • line 76 - capitalize f in fixes

changelogs/changelog.yml

  • line 388 - fixed should be fixes , also capitalize F
  • line 407 - capitalize f in fixes
  • line 409 - consider removing word ‘this’ and start sentence with “Also cleans up…”
  • line 581 - 588-zos_copy-emergenxy-backup.yml should be emergency not emergenxy

for meta/runtime.yml

  • are we still supoorting 2.9? should ansible-core version be bumped up?

@ddimatos
Copy link
Collaborator Author

CHANGELOG.rst

* line 49, add a space after the dash

* line 70 - fixed should be fixes , also capitalize F

* line 76 - capitalize f in fixes

changelogs/changelog.yml

* line 388 - fixed should be fixes , also capitalize F

* line 407 - capitalize f in fixes

* line 409 - consider removing word ‘this’ and start sentence with “Also cleans up…”

* line 581 - 588-zos_copy-emergenxy-backup.yml should be emergency not emergenxy

for meta/runtime.yml

* are we still supoorting 2.9? should ansible-core version be bumped up?

Thanks @ketankelkar , ill make the edits although not keen on editing what was generated, those files you reference are generated based on our changelog fragments, this is why I commented when we get to the point they are where we like them to be we can drop the release_notes.rst, changelog fragments are a what feeds the tooling so spelling and other errors will come through.

As for 2.9 , yes we are still supporting 2.9 through September 29th 2023, we support it till AAP 1.2 goes out of service.

@ddimatos
Copy link
Collaborator Author

Also note I did not put a limit on the ansible version this time around because it will allow users to easily try the dev branch (ansible-core 2.15) , when we GA to Hub we can determine the upper bound at that time of what is required by RH.

@ddimatos
Copy link
Collaborator Author

Most the edits are in place, I can't change line 581 - 588-zos_copy-emergenxy-backup.yml should be emergency not emergenxy because those are the actual fragments and unfortunately are misspelled, we already removed those fragments from our history thus if i change them here I have no way to change them in the older branches.

Signed-off-by: ddimatos <dimatos@gmail.com>
Copy link
Collaborator

@ketankelkar ketankelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ddimatos ddimatos merged commit b9ea1da into release-v1.5.0-beta.1 Feb 22, 2023
@ddimatos ddimatos deleted the doc/390-630-649/release-activities branch February 22, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants