-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/v1.4.0/zos copy dirs #561
Enhancement/v1.4.0/zos copy dirs #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay so far... just wanted you to know I looked through it. Let me know when you're ready for formal review - richp
Thanks for the preliminary review @richp405. I think this PR is ready for a formal review, especially around the test cases. I didn't add new ones for #554, as that is somewhat tested already by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SUMMARY
Fixes #553 and #554.
ISSUE TYPE
COMPONENT NAME
zos_copy
ADDITIONAL INFORMATION
For #553: added a test case for the creation of missing parents.
For #554: the module now only gets the original permissions for files and subdirectories that will be overwritten, instead of walking the whole directory tree for the destination.
Additionally, when the source is a file and the destination is a directory, the module computes the final destination path before trying to backup. Before this change, it tried to backup the whole destination directory, when it only needed to backup one file.