Gh issue 329 ddname #333

fernandofloresg · 2022-06-09T20:37:04Z

SUMMARY

Fixed a typo in module_utils/job.py at line 59 in ibm_zos_core version 1.3.4 and forward ported to the development branch as well.

Code was updated from:

dd_name = parsed_args.get("ddname") or ""

To:

dd_name = parsed_args.get("dd_name") or ""

Fixes git issue #329

This pull request also includes changes to support:

Ansible 2.11
ansible-test's included in 2.11
galaxy-importer==0.4.5

This pull request also contains the initial commit for using changelog as well as updates to prepare for execution environments.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module_utils/job.py
tests/functional/modules/test_zos_job_output_func.py

ADDITIONAL INFORMATION

…d_name

fernandofloresg · 2022-06-09T20:38:19Z

richp405

I like that new test, to make sure only 1 ddname comes back. Thanks for doing this.

Signed-off-by: ddimatos <dimatos@gmail.com>

…eprecated Signed-off-by: ddimatos <dimatos@gmail.com>

Signed-off-by: ddimatos <dimatos@gmail.com>

…used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com>

Signed-off-by: ddimatos <dimatos@gmail.com>

ddimatos · 2022-06-17T02:23:28Z

Internal CI/CD regression completion

ddimatos · 2022-06-17T02:25:08Z

@fernandofloresg and @richp405 - maybe take a second look as I added to this PR after it had been approved. Its all the latest collection requirements and an updated test case.

richp405

Documentation-mania! Only one question, which I'm sure you just fought through:

in test_ensure_tmp_cleanup(ansible_zos_module), you changed 'ls -l' to 'ls'. My understanding is 'ls -l' puts 1 file per line, where 'ls' may not... wouldn't that adversely impact the 'stdout_lines' value? I'm asking for my own edification, since it passed the scan test.

fernandofloresg · 2022-06-17T14:37:21Z

LGTM

richp405

Repeating approval

ddimatos · 2022-06-17T18:22:42Z

Documentation-mania! Only one question, which I'm sure you just fought through:

in test_ensure_tmp_cleanup(ansible_zos_module), you changed 'ls -l' to 'ls'. My understanding is 'ls -l' puts 1 file per line, where 'ls' may not... wouldn't that adversely impact the 'stdout_lines' value? I'm asking for my own edification, since it passed the scan test.

@richp405 that is a very good question, let me start by stating why I did not use ls -la, its because in the final check i did not want to take a chance with the spaces that separated all the added information eg, permissions, owner, group, etc and really just wanted the file name.

You are correct that ls -la returns multiple lines
thus mapping to a list but if you notice we are passing ls into the ansible command module and getting the result from stdout_lines ....

stat_dir_list = list(stat_dir.contacted.values())[0].get("stdout_lines")

which by definition - "When stdout is returned, Ansible always provides a list of strings, each containing one item per line from the original output." thus no matter the command used, a list will be returned.

To confirm, I dumped the output with:

        print(stat_dir_list)
        print("Elements of the List:")
        for x in stat_dir_list:
          print(x)

Resulted in:

['ansible_command_payload_x81u5gmw', 'inetd.stdout', 'profile', 'telnetd.stderr']

Elements of the List:
ansible_command_payload_x81u5gmw
inetd.stdout
profile
telnetd.stderr

Thanks for looking its always good to have extra eyes on things.

ddimatos · 2022-06-17T18:25:40Z

Thanks @richp405 and @fernandofloresg , was a great collaboration to get this all into dev!!!

… latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com>

…anges available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com>

* Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com>

* added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com>

) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Feature/2621/regex operator action query (#313) * added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com>

* Added indentation option to the module * Added blockinfile tests and modified helper to assert taking into account spaces and line breaks * Add changelog frament to release. Signed-off-by: ddimatos <dimatos@gmail.com> * Merge dev into NAZARE-8880-prepend-spaces to handle the divergence (#342) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Feature/2621/regex operator action query (#313) * added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29a. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Rich Parker <richp405@gmail.com> Co-authored-by: Ivan Moreno <iamorenosoto@gmail.com>

#346) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Feature/2621/regex operator action query (#313) * added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d59465016fad78f9c0e1c594b576a00fff. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Nazare 8880 prepend spaces (#317) * Added indentation option to the module * Added blockinfile tests and modified helper to assert taking into account spaces and line breaks * Add changelog frament to release. Signed-off-by: ddimatos <dimatos@gmail.com> * Merge dev into NAZARE-8880-prepend-spaces to handle the divergence (#342) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on…

* Modifed zos_blockinfile for using the dmod -f option * Created functional tests for force option * Cleaned blank spaces for sanity test * Update branch NAZARE-8838-force-option branch with the latest from dev (#346) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Feature/2621/regex operator action query (#313) * added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d59465016fad78f9c0e1c594b576a00fff. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Nazare 8880 prepend spaces (#317) * Added indentation option to the module * Added blockinfile tests and modified helper to assert taking into account spaces and line breaks * Add changelog frament to release. Signed-off-by: ddimatos <dimatos@gmail.com> * Merge dev into NAZARE-8880-prepend-spaces to handle the divergence (#342) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Pa…

* Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Feature/2621/regex operator action query (#313) * added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d59465016fad78f9c0e1c594b576a00fff. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Nazare 8880 prepend spaces (#317) * Added indentation option to the module * Added blockinfile tests and modified helper to assert taking into account spaces and line breaks * Add changelog frament to release. Signed-off-by: ddimatos <dimatos@gmail.com> * Merge dev into NAZARE-8880-prepend-spaces to handle the divergence (#342) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exc…

* zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * change to call submit, adding timeout parameter. Need to test pds and uss variants. * removed prior code comments * corrections for pep8 issues * Fixed MissingImport function call * Changed import statements that were hanging up the build wrapped zoau in try/except changed spacing on from collections * tweaking jobs.py importer for zoau stuff * added missing zoaau import import * More decoration control on imports * changed zos_job_output to do a full list request and filter This is to handle an issue where zoau may not see job by job name or owner. * saved the job.py file with the search change needed. * fixed under-indent (pep8) @368 * Disable timeout test until ZOAU timout is supported as it was once in REXX Signed-off-by: ddimatos <dimatos@gmail.com> * Update branch enh6778 pull reqeust 318 with the latest from dev (#348) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Feature/2621/regex operator action query (#313) * added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d59465016fad78f9c0e1c594b576a00fff. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Nazare 8880 prepend spaces (#317) * Added indentation option to the module * Added blockinfile tests and modified helper to assert taking into account spaces and line breaks * Add changelog frament to release. Signed-off-by: ddimatos <dimatos@gmail.com> * Merge dev into NAZARE-8880-prepend-spaces to handle the divergence (#342) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank l…

fernandofloresg added 2 commits June 9, 2022 09:45

Fixed typo for dd_name that prevented job output filtering based on d…

37c4fcb

…d_name

Added functional tests to verify ddname filtering

cb61427

fernandofloresg requested review from richp405 and ddimatos June 9, 2022 20:37

richp405 approved these changes Jun 9, 2022

View reviewed changes

ddimatos added 10 commits June 10, 2022 22:05

Update Readme to reflect supported ansible version

5013335

Signed-off-by: ddimatos <dimatos@gmail.com>

Upate release note to reflect patched version 1.3.x

3ccc76d

Signed-off-by: ddimatos <dimatos@gmail.com>

Update galaxy.yml with added build_ignore and authors

24b89ff

Signed-off-by: ddimatos <dimatos@gmail.com>

Update artifacts to correctly reflect execution environments

e2467cb

Signed-off-by: ddimatos <dimatos@gmail.com>

Update module with boolean bug fix and version released

c9d1cf5

Signed-off-by: ddimatos <dimatos@gmail.com>

Update modules docs and version released

3adc60b

Signed-off-by: ddimatos <dimatos@gmail.com>

Update error message for clarity

01d58ba

Signed-off-by: ddimatos <dimatos@gmail.com>

Update sanity tests to remove a doc reference

1532167

Signed-off-by: ddimatos <dimatos@gmail.com>

First commit for changelog support and backported release fragemetns

12845d9

Signed-off-by: ddimatos <dimatos@gmail.com>

Update changelog fragments because of yamlint blank lines

86b85a9

Signed-off-by: ddimatos <dimatos@gmail.com>

ddimatos closed this Jun 11, 2022

ddimatos reopened this Jun 11, 2022

update zos_fetch test case to remove testing the sftp port which is d…

8c63299

…eprecated Signed-off-by: ddimatos <dimatos@gmail.com>

ddimatos closed this Jun 13, 2022

ddimatos reopened this Jun 13, 2022

ddimatos added 9 commits June 13, 2022 12:06

update test case with verbosity to troubleshoot file count

65474b0

Signed-off-by: ddimatos <dimatos@gmail.com>

update test case with verbosity to troubleshoot file count

604d56b

Signed-off-by: ddimatos <dimatos@gmail.com>

Update the test case to add 1 to the count for the added profile

20f4376

Signed-off-by: ddimatos <dimatos@gmail.com>

Correct missing whitespace around arithmetic operator

f755062

Signed-off-by: ddimatos <dimatos@gmail.com>

Chaning src file because I think there is a race condition where its …

30232aa

…used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com>

Chaning src file because I think there is a race condition where its …

5ac3762

…used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com>

add more debug stmt's to the test case

17ed1cc

Signed-off-by: ddimatos <dimatos@gmail.com>

Added more debug to the test

d229cfa

Signed-off-by: ddimatos <dimatos@gmail.com>

Update test case with more debug

652e4c4

Signed-off-by: ddimatos <dimatos@gmail.com>

udpate test case to correctly validate copied file

bb8aa85

Signed-off-by: ddimatos <dimatos@gmail.com>

richp405 self-requested a review June 17, 2022 13:34

richp405 approved these changes Jun 17, 2022

View reviewed changes

fernandofloresg requested a review from richp405 June 17, 2022 14:33

richp405 approved these changes Jun 17, 2022

View reviewed changes

ddimatos merged commit 0023590 into dev Jun 17, 2022

ddimatos deleted the GHIssue-329-ddname branch June 17, 2022 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gh issue 329 ddname #333

Gh issue 329 ddname #333

fernandofloresg commented Jun 9, 2022 •

edited by ddimatos

Loading

fernandofloresg commented Jun 9, 2022

richp405 left a comment

ddimatos commented Jun 17, 2022

ddimatos commented Jun 17, 2022

richp405 left a comment

fernandofloresg commented Jun 17, 2022

richp405 left a comment

ddimatos commented Jun 17, 2022 •

edited

Loading

ddimatos commented Jun 17, 2022

Gh issue 329 ddname #333

Gh issue 329 ddname #333

Conversation

fernandofloresg commented Jun 9, 2022 • edited by ddimatos Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

fernandofloresg commented Jun 9, 2022

richp405 left a comment

Choose a reason for hiding this comment

ddimatos commented Jun 17, 2022

ddimatos commented Jun 17, 2022

richp405 left a comment

Choose a reason for hiding this comment

fernandofloresg commented Jun 17, 2022

richp405 left a comment

Choose a reason for hiding this comment

ddimatos commented Jun 17, 2022 • edited Loading

ddimatos commented Jun 17, 2022

fernandofloresg commented Jun 9, 2022 •

edited by ddimatos

Loading

ddimatos commented Jun 17, 2022 •

edited

Loading