Fixed module param in win_dns_record.ps1 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pickup, I've pushed a commit that adds a changelog fragment as well. Why this was changed is just a missed error in the review process. I don't think there are any plans on changing the name. If there was we would use an alias first to not make a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This mr changes the
$module.Params.serverback to$module.Params.computer_namesince server is not recognized in the module as an accepted parameter. And computer_name has been used before. If you want to change to server. I would suggest to document this correctly as a breaking change :)ISSUE TYPE
COMPONENT NAME
win_dns_record
Fixes #276