Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dict comprehension in plugins, part 2 #8822

Merged
merged 2 commits into from
Sep 5, 2024
Merged

use dict comprehension in plugins, part 2 #8822

merged 2 commits into from
Sep 5, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Sep 1, 2024

SUMMARY

Another PR to mass-replace the construct dict((k, v) for k, v in d if condition) with dict comprehensions: {k: v for k, v in d if condition}

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/lookup/credstash.py
plugins/module_utils/identity/keycloak/keycloak.py
plugins/module_utils/mh/deco.py
plugins/module_utils/redfish_utils.py
plugins/module_utils/scaleway.py
plugins/modules/etcd3.py
plugins/modules/gitlab_project.py
plugins/modules/hwc_ecs_instance.py
plugins/modules/hwc_evs_disk.py
plugins/modules/hwc_vpc_eip.py
plugins/modules/hwc_vpc_peering_connect.py
plugins/modules/hwc_vpc_port.py
plugins/modules/hwc_vpc_subnet.py
plugins/modules/ipa_otptoken.py
plugins/modules/keycloak_user_federation.py
plugins/modules/lxc_container.py
plugins/modules/proxmox_kvm.py
plugins/modules/scaleway_security_group.py
plugins/modules/ufw.py
plugins/modules/vmadm.py

@russoz russoz changed the title [WIP] use dict comprehension in plugins, part 2 use dict comprehension in plugins, part 2 Sep 1, 2024
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Akasurde @DenBeke @Lunik @Nosmoht @QijunPan @Shaps @Thulium-Drake @TommyLike @UnderGreen @abarbare @ahtik @bcoca @Bhavya06 @cloudnull @edisonxiang @eikef @evrardjp @fishman @freesky-edward @helldorado @huaweicloud @hwDCN @jasperla @joshainglis @jpdasma @justchris1 @jyundt @karmab @krauthosting @laurpaum @lgatellier @marwatk @mator @mattock @metanovii @mraineri @ndclt @nejch @niuzhenguo @ovcharenko @pyykkis @rajeevkallur @remyleone @renxulei @scathatheworm @scodeman @sh0shin @suukit @thomasbach-dev @tomasg2012 @troy2914 @waheedi @xen0l @xmadsen @xuxiaowei0512 @yanzhangi @zanssa @zengchen1024 @zhongjun2
click here for bot help

@ansibullbot ansibullbot added cloud identity lookup lookup plugin module module module_utils module_utils plugins plugin (any type) labels Sep 1, 2024
@felixfontein felixfontein added the backport-9 Automatically create a backport for the stable-9 branch label Sep 2, 2024
@felixfontein felixfontein merged commit 7e978c7 into ansible-collections:main Sep 5, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 5, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/7e978c77b4a1d3f317f65a544ec5f3051161fba0/pr-8822

Backported as #8832

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Sep 5, 2024
@russoz @patchback
use dict comprehension in plugins, part 2 (#8822)
7373a13 
* use dict comprehension in plugins

* add changelog frag

(cherry picked from commit 7e978c7)
@patchback patchback bot mentioned this pull request Sep 5, 2024
Merged
felixfontein pushed a commit that referenced this pull request Sep 5, 2024
@patchback @russoz
[PR #8822/7e978c77 backport][stable-9] use dict comprehension in plug…
7c3b441 
…ins, part 2 (#8832)

use dict comprehension in plugins, part 2 (#8822)

* use dict comprehension in plugins

* add changelog frag

(cherry picked from commit 7e978c7)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the dict-comprehension-2 branch September 5, 2024 20:13
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@russoz @aioue
use dict comprehension in plugins, part 2 (ansible-collections#8822)
f48ae87 
* use dict comprehension in plugins

* add changelog frag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch cloud identity lookup lookup plugin module_utils module_utils module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein