Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java_cert: owner, group, mode arguments enabled #8116

Merged
merged 10 commits into from
Mar 25, 2024
Merged

java_cert: owner, group, mode arguments enabled #8116

merged 10 commits into from
Mar 25, 2024

Conversation

dborisov
Copy link
Contributor

SUMMARY

Enable ability to set owner, group and mode for keystore file

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

community.general.java_cert

ADDITIONAL INFORMATION
  java_cert:
    cert_alias: alias
    cert_path: /tmp/cert.pem
    keystore_path: "/tmp/keystore.jks"
    keystore_pass: "secret"
    keystore_create: true
    trust_cacert: true
    owner: "testuser"
    group: "testgroup"
    mode: "0600"

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @absynth76 @haad
click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) labels Mar 19, 2024
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 19, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Mar 20, 2024
felixfontein
felixfontein reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please add a changelog fragment. Thanks.

plugins/modules/java_cert.py Outdated Show resolved Hide resolved
plugins/modules/java_cert.py Outdated Show resolved Hide resolved
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 22, 2024
@dborisov
Copy link
Contributor Author

I've resolved previous comments. Can we backport this change to 6 and 7 stable versions?

@dborisov dborisov requested a review from felixfontein March 22, 2024 09:50
@felixfontein
Copy link
Collaborator

I've resolved previous comments. Can we backport this change to 6 and 7 stable versions?

stable-6 and stable-7 only receive bugfixes (and stable-6 only major bugfixes and security fixes), so no, since this is a new feature. Sorry.

@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 24, 2024
felixfontein
felixfontein reviewed Mar 24, 2024
View reviewed changes
plugins/modules/java_cert.py Show resolved Hide resolved
changelogs/fragments/8116-java_cert-enable-owner-group-mode-args.yml Outdated Show resolved Hide resolved
plugins/modules/java_cert.py Outdated Show resolved Hide resolved
plugins/modules/java_cert.py Outdated Show resolved Hide resolved
dborisov and others added 3 commits March 25, 2024 09:15
@dborisov @felixfontein
Update changelogs/fragments/8116-java_cert-enable-owner-group-mode-ar…
f4d4c0a 
…gs.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
@dborisov @felixfontein
Update plugins/modules/java_cert.py
3846ba6 
Co-authored-by: Felix Fontein <felix@fontein.de>
@dborisov @felixfontein
Update plugins/modules/java_cert.py
82042ea 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 25, 2024
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 25, 2024
felixfontein
felixfontein approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Will merge later today if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 25, 2024
@felixfontein felixfontein merged commit 4f758bf into ansible-collections:main Mar 25, 2024
133 checks passed
@patchback Patchback
Copy link

patchback bot commented Mar 25, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/4f758bfb84c639f3ce092a6dbba30a5e42bbd062/pr-8116

Backported as #8152

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@dborisov thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Mar 25, 2024
@dborisov @patchback
java_cert: owner, group, mode arguments enabled (#8116)
06ef3dd 
* java_cert: owner, group, mode arguments enabled

* java_cert: sanity fix

* add changelog fragment

* remove duplication in documentation

* refactor change detection

* fix indentation

* Update changelogs/fragments/8116-java_cert-enable-owner-group-mode-args.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/java_cert.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/java_cert.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* update options

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 4f758bf)
@patchback patchback bot mentioned this pull request Mar 25, 2024
Merged
felixfontein pushed a commit that referenced this pull request Mar 25, 2024
@patchback @dborisov
[PR #8116/4f758bfb backport][stable-8] java_cert: owner, group, mode …
9e64101 
…arguments enabled (#8152)

java_cert: owner, group, mode arguments enabled (#8116)

* java_cert: owner, group, mode arguments enabled

* java_cert: sanity fix

* add changelog fragment

* remove duplication in documentation

* refactor change detection

* fix indentation

* Update changelogs/fragments/8116-java_cert-enable-owner-group-mode-args.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/java_cert.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/java_cert.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* update options

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 4f758bf)

Co-authored-by: Denis Borisov <dborisov86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dborisov @ansibullbot @felixfontein