ini_file - add feature 'section_has_values' #7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
felixfontein
added
check-before-release
felixfontein
reviewed
Nov 9, 2023
ansibullbot
removed
the
needs_revision
jpmens
reviewed
Nov 10, 2023
ansibullbot
added
needs_rebase
|
needs_info |
ansibullbot
added
the
needs_info
|
@jakob-bebop this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
|
ansibullbot
removed
the
needs_info
jakob-bebop
force-pushed
the
ini_file/section_has-2
branch
from
2dccddb to
fdfbaf6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
|
If nobody objects, I'll merge this on the upcoming weekend (after applying the remaining suggestions if they haven't been applied yet). |
felixfontein
merged commit be4d5b7
into
ansible-collections:main
132 of 133 checks passed
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8250 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
* insert new code * add changelog * add argument_spec * sanity check * docstring version_added * version-added-must-be-major-or-minor * Update plugins/modules/ini_file.py Co-authored-by: Felix Fontein <felix@fontein.de> * check for default value `None` * typo in example * add integration test and rename option * add license * update "version added" in docstring * insert new code * remove whitespace * update examples * support exclusive, allow_no_value, multiple values in section_has_values * prefer Todd's variable naming in loops * resolve number clash in file names * pass sanity test validate-modules * Documentation updates --------- Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Todd Lewis <todd_lewis@unc.edu> (cherry picked from commit be4d5b7)
felixfontein
removed
the
check-before-release
|
@jakob-bebop @utoddl thanks for your contributions! |
felixfontein
pushed a commit
that referenced
this pull request
Apr 20, 2024
…n_has_values' (#8250) ini_file - add feature 'section_has_values' (#7505) * insert new code * add changelog * add argument_spec * sanity check * docstring version_added * version-added-must-be-major-or-minor * Update plugins/modules/ini_file.py Co-authored-by: Felix Fontein <felix@fontein.de> * check for default value `None` * typo in example * add integration test and rename option * add license * update "version added" in docstring * insert new code * remove whitespace * update examples * support exclusive, allow_no_value, multiple values in section_has_values * prefer Todd's variable naming in loops * resolve number clash in file names * pass sanity test validate-modules * Documentation updates --------- Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Todd Lewis <todd_lewis@unc.edu> (cherry picked from commit be4d5b7) Co-authored-by: Jakob Lund <jakob@avforlaget.dk>
aretrosen
pushed a commit
to aretrosen/community.general
that referenced
this pull request
Apr 22, 2024
* insert new code * add changelog * add argument_spec * sanity check * docstring version_added * version-added-must-be-major-or-minor * Update plugins/modules/ini_file.py Co-authored-by: Felix Fontein <felix@fontein.de> * check for default value `None` * typo in example * add integration test and rename option * add license * update "version added" in docstring * insert new code * remove whitespace * update examples * support exclusive, allow_no_value, multiple values in section_has_values * prefer Todd's variable naming in loops * resolve number clash in file names * pass sanity test validate-modules * Documentation updates --------- Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Todd Lewis <todd_lewis@unc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ini_file: Add an optional parameter
section_has. If the target ini file contains more than onesection, usesection_hasto specify which one should be updated.Use case: In wireguard config there can be multiple [Peer] sections. See example in source code doc string
ISSUE TYPE
COMPONENT NAME
ini_file