@vj-codes added the screenshot. I don't see why we have to wait ? Since the issue is not assigned yet we can ask someone the contributor to make changes to the proguard rules as well.

@epicadk yess I've already posted on zulip, but the PRs linked with that issue are made against the community guidelines by contributors who were not assigned to it so they can't be reopened .
Someone will surely claim it soon:)

@vj-codes can the tag be updated now or do I still need to make changes?

@epicadk the apk size by this PR is 7.24 but earlier it was 8.8
Although it's decreased the size isn't 2.44 , any idea why?
And why did you not shrink for app-debug.apk because that's the apk we primarily downloaded for testing ?

@epicadk the apk size by this PR is 7.24 but earlier it was 8.8
Although it's decreased the size isn't 2.44 , any idea why?
And why did you not shrink for app-debug.apk because that's the apk we primarily downloaded for testing ?

Because obfuscation makes it harder to debug so shrinking is generally only performed on the release apk.

Are you talking about after installation size? Because I've added the screenshot that compares the two apks using android studios inbuilt apk analyser.

@epicadk the apk size by this PR is 7.24 but earlier it was 8.8
Although it's decreased the size isn't 2.44 , any idea why?
And why did you not shrink for app-debug.apk because that's the apk we primarily downloaded for testing ?

Because obfuscation makes it harder to debug so shrinking is generally only performed on the release apk.

Are you talking about after installation size? Because I've added the screenshot that compares the two apks using android studios inbuilt apk analyser.

@vj-codes can you confirm this ?

@epicadk yes I was speaking about installation size

As stated in the pr description, the app apk size has reduced from 4 to nearly 2.3 mb.
Tested the pr locally on emulator as well, the app works perfectly fine.

But I want to ask why have you written lines 28-34 in progaurd-rule.pro ? 🤔

But I want to ask why have you written lines 28-34 in progaurd-rule.pro ? 🤔

As explained in the docs itself. Those classes are not required for processing. You can see over here that android studio recommended using the -dontwarn option.

I tested the app and it was working fine without it so I used the -dontwarn options. I hope this clarifies it. : )

As stated in the pr description, the app apk size has reduced from 4 to nearly 2.3 mb.
Tested the pr locally on emulator as well, the app works perfectly fine.

But I want to ask why have you written lines 28-34 in progaurd-rule.pro ? 🤔

Can you link the images / videos to this as well. Remember to test the release build and not the debug one 😉 .

But I want to ask why have you written lines 28-34 in progaurd-rule.pro ? 🤔

As explained in the docs itself. Those classes are not required for processing. You can see over here that android studio recommended using the -dontwarn option.

I tested the app and it was working fine without it so I used the -dontwarn options. I hope this clarifies it. : )

hmm ok 👍

As stated in the pr description, the app apk size has reduced from 4 to nearly 2.3 mb.
Tested the pr locally on emulator as well, the app works perfectly fine.
But I want to ask why have you written lines 28-34 in progaurd-rule.pro ? 🤔

Can you link the images / videos to this as well. Remember to test the release build and not the debug one 😉 .

which image/video do you want me to link ? And yes i've posted the screenshot for release build only 😂

which image/video do you want me to link ? And yes i've posted the screenshot for release build only 😂

The images/video that show that the app is running fine in the release build.

I had tested previously the debug build variant which was working fine, but on testing the release variant, I am not able to login. It shows the error please check your internet connection, even after proper wifi connection.
@epicadk can you please look into this and fix it ?

@epicadk can you please look into this and fix it ?

It's working for me. Although I just add the proguard rules to the debug build because I can't install unsinged apk on my device. Can you try testing it locally? I'll find a way to install the release apk on my device.

@epicadk can you please look into this and fix it ?

It's working for me. Although I just add the proguard rules to the debug build because I can't install unsinged apk on my device. Can you try testing it locally? I'll find a way to install the release apk on my device.

Is you release apk running fine ? Or are you talking about the debug one ?🤔

@CodeChamp-SS the debug build build with the proguard rules set up is working fine. Can't test the release build ad explained above.

@CodeChamp-SS the debug build build with the proguard rules set up is working fine. Can't test the release build ad explained above.

ya the build one is running fine but I am facing issue in the release apk.

@CodeChamp-SS the debug build build with the proguard rules set up is working fine. Can't test the release build ad explained above.

try creating a signed apk using generate signed bundle/apk in build section and then install it either in your emulator or physical device.

@CodeChamp-SS the debug build build with the proguard rules set up is working fine. Can't test the release build ad explained above.

try creating a signed apk using generate signed bundle/apk in build section and then install it either in your emulator or physical device.

Yep I was just doing that.

@CodeChamp-SS the debug build build with the proguard rules set up is working fine. Can't test the release build ad explained above.

try creating a signed apk using generate signed bundle/apk in build section and then install it either in your emulator or physical device.

Yep I was just doing that.

hmm so what problem are you facing exactly ? I may be able to help

hmm so what problem are you facing exactly ? I may be able to help

Haha thanks but I was just busy with a couple of stuff and never ended up setting up the keystore. The error is due to the file Baseurl.kt if you change the release build url to the current mentorship backend one it will work. However I don't think that is in the scope of this pr. What do you think?

hmm so what problem are you facing exactly ? I may be able to help

Haha thanks but I was just busy with a couple of stuff and never ended up setting up the keystore. The error is due to the file Baseurl.kt if you change the release build url to the current mentorship backend one it will work. However I don't think that is in the scope of this pr. What do you think?

didn't get what you are trying to say 😅

didn't get what you are trying to say 😅

The error please check your internet connection is due to the file baseurl.kt having a different url in the release build. So if you do want to test the release build you can try changing that file and it should work : ).

didn't get what you are trying to say 😅

The error please check your internet connection is due to the file baseurl.kt having a different url in the release build. So if you do want to test the release build you can try changing that file and it should work : ).

What changes ? I think BaseUrl.kt file remains the same 🤔. Moreover I think you should do something like -keep class org.systers.mentorship.remote.* {*;} in the proguard-rulers.pro file

didn't get what you are trying to say 😅

The error please check your internet connection is due to the file baseurl.kt having a different url in the release build. So if you do want to test the release build you can try changing that file and it should work : ).

What changes ? I think BaseUrl.kt file remains the same 🤔. Moreover I think you should do something like -keep class org.systers.mentorship.remote.* {*;} in the proguard-rulers.pro file

but after that also same error is occuring.

didn't get what you are trying to say 😅

The error please check your internet connection is due to the file baseurl.kt having a different url in the release build. So if you do want to test the release build you can try changing that file and it should work : ).

What changes ? I think BaseUrl.kt file remains the same 🤔. Moreover I think you should do something like -keep class org.systers.mentorship.remote.* {*;} in the proguard-rulers.pro file

Yes I haven't made any changes to the BaseUrl.kt file. The bug exists even before this pr. You can try to build the release apk from the develop branch and it would still show the same error as for the release build it returns the elastic beanstalk url.

I don't think we need to keep the remote package because it'll work even after obfuscation but if I have missed anything can you explain why we would want to add remote to the keep rules? 🤔

didn't get what you are trying to say 😅

The error please check your internet connection is due to the file baseurl.kt having a different url in the release build. So if you do want to test the release build you can try changing that file and it should work : ).

What changes ? I think BaseUrl.kt file remains the same 🤔. Moreover I think you should do something like -keep class org.systers.mentorship.remote.* {*;} in the proguard-rulers.pro file

Yes I haven't made any changes to the BaseUrl.kt file. The bug exists even before this pr. You can try to build the release apk from the develop branch and it would still show the same error as for the release build it returns the elastic beanstalk url.

oh.. okk

didn't get what you are trying to say 😅

The error please check your internet connection is due to the file baseurl.kt having a different url in the release build. So if you do want to test the release build you can try changing that file and it should work : ).

What changes ? I think BaseUrl.kt file remains the same 🤔. Moreover I think you should do something like -keep class org.systers.mentorship.remote.* {*;} in the proguard-rulers.pro file

Yes I haven't made any changes to the BaseUrl.kt file. The bug exists even before this pr. You can try to build the release apk from the develop branch and it would still show the same error as for the release build it returns the elastic beanstalk url.

oh.. okk

didn't get what you are trying to say 😅

The error please check your internet connection is due to the file baseurl.kt having a different url in the release build. So if you do want to test the release build you can try changing that file and it should work : ).

What changes ? I think BaseUrl.kt file remains the same 🤔. Moreover I think you should do something like -keep class org.systers.mentorship.remote.* {*;} in the proguard-rulers.pro file

I don't think we need to keep the remote package because it'll work even after obfuscation but if I have missed anything can you explain why we would want to add remote to the keep rules? 🤔

Nah don't change anything, I thought maybe adding some of those files might fix this issue. But if it existed previously too then it's fine :-)

@vj-codes can you confirm if this can be marked ready to merge as tested by @CodeChamp-SS ? ( The error that is occurring is unrelated to the changes made).

@epicadk so we have an issue with release build right? because of the backend URL? Can you create an issue just to document that for later.

I see @CodeChamp-SS tested the debug apk, I will merge