Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): restore element's display mode and more... #143

Merged
merged 1 commit into from
Feb 2, 2017
Merged

fix(api): restore element's display mode and more... #143

merged 1 commit into from
Feb 2, 2017

Conversation

ThomasBurleson
Copy link
Contributor

  • fxShow and fxHide should restore original display modes when deactivating
  • combination uses of fxHide + fxShow should work properly
  • static uses of fxHide="" should hide the hosting elmement

fixes #140, fixes #141.

@ThomasBurleson ThomasBurleson force-pushed the wip/thomasb/fix-show-hide-combos branch 2 times, most recently from 7f2b07b to 7434744 Compare January 30, 2017 00:20
@ThomasBurleson
Copy link
Contributor Author

@d3viant0ne - please review and comment with LGTM if all good. Thx.

@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.5 milestone Jan 30, 2017
This was referenced Jan 30, 2017
Closed
Closed
@ThomasBurleson ThomasBurleson changed the title fix(api): restore orig display mode and more... fix(api): restore element's display mode and more... Jan 30, 2017
@kara kara added pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: needs rebase and removed pr: needs presubmit pr: merge ready This PR is ready for the caretaker to presubmit and merge labels Feb 2, 2017
@ThomasBurleson ThomasBurleson force-pushed the wip/thomasb/fix-show-hide-combos branch from 7434744 to c10a575 Compare February 2, 2017 23:51
@ThomasBurleson
fix(api): restore orig display mode and more...
3bde7c9 
*  fxShow and fxHide should restore original display modes when deactivating
*  combination uses of fxHide + fxShow should work properly
*  static uses of `fxHide=""` should hide the hosting elmement

fixes #140, fixes #141.
@ThomasBurleson ThomasBurleson force-pushed the wip/thomasb/fix-show-hide-combos branch from c10a575 to 3bde7c9 Compare February 2, 2017 23:53
@kara kara added pr: merge ready This PR is ready for the caretaker to presubmit and merge and removed pr: needs presubmit labels Feb 2, 2017
@kara kara merged commit d269d73 into master Feb 2, 2017
@ThomasBurleson ThomasBurleson deleted the wip/thomasb/fix-show-hide-combos branch February 3, 2017 16:02
karlhaas pushed a commit to karlhaas/flex-layout that referenced this pull request May 3, 2017
@ThomasBurleson @karlhaas
fix(api): restore orig display mode and more... (angular#143)
95718b5 
fixes angular#140, fixes angular#141.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshwiens joshwiens Awaiting requested review from joshwiens

Assignees
No one assigned
Labels
cla: yes pr: merge ready This PR is ready for the caretaker to presubmit and merge
Projects
None yet
Milestone
v2.0.0-beta.5
Development

Successfully merging this pull request may close these issues.

fxHide breaks style of non-"display: box" elements fxHide / fxShow ignores breakpoint aliases
3 participants
@ThomasBurleson @kara @googlebot