Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement MediaTrigger to allow manual activations #997

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

ThomasBurleson
Copy link
Contributor

@ThomasBurleson ThomasBurleson commented Jan 15, 2019

The Windows MatchMedia API announces breakpoint activations during viewport resizing.
For some scenarios, developers need support for manual activations (without resizing).

Such features are useful for:

  • for SSR
  • for designer environments

    for immediate rendering of layouts for specific (1..n) breakpoints

@CaerusKaru CaerusKaru self-assigned this Jan 15, 2019
@CaerusKaru CaerusKaru added this to the 7.0.0-beta.24 milestone Jan 15, 2019
@ThomasBurleson ThomasBurleson force-pushed the thomas/feat-media-trigger branch 2 times, most recently from 088af1e to 3636b6c Compare January 15, 2019 21:35
@ThomasBurleson
Copy link
Contributor Author

ping @CaerusKaru

Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes, o/w looks good!

src/lib/core/media-trigger/media-trigger.ts Outdated Show resolved Hide resolved
src/lib/core/media-trigger/media-trigger.ts Outdated Show resolved Hide resolved
src/lib/core/media-trigger/media-trigger.ts Outdated Show resolved Hide resolved
@ThomasBurleson ThomasBurleson force-pushed the thomas/feat-media-trigger branch from 3636b6c to eb3a4d4 Compare January 15, 2019 21:53
src/lib/core/tokens/library-config.ts Outdated Show resolved Hide resolved
src/lib/core/public-api.ts Show resolved Hide resolved
@ThomasBurleson ThomasBurleson force-pushed the thomas/feat-media-trigger branch 2 times, most recently from d41c70e to c2da429 Compare January 15, 2019 22:16
…ions

Windows MatchMedia API announces breakpoint activations during viewport resizing.
For ome usage scenarios, support for manual activations is needed (without resizing).

* immediate rendering of layouts for specific (1..n) breakpoints
* for SSR
@ThomasBurleson ThomasBurleson force-pushed the thomas/feat-media-trigger branch from c2da429 to 4c6660d Compare January 15, 2019 22:18
Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru CaerusKaru added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit and removed pr: needs review labels Jan 15, 2019
@ThomasBurleson ThomasBurleson merged commit 66e7463 into master Jan 15, 2019
@CaerusKaru CaerusKaru deleted the thomas/feat-media-trigger branch January 15, 2019 22:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants