Skip to content

Orientation media queries defined in orientation-break-points.ts seem to be using incorrect pluralisation #763

Closed
@Mufasa

Description

Bug, feature request, or proposal:

I think there is a bug in the file src/lib/core/breakpoints/data/orientation-break-points.ts

What is the expected behavior?

The media queries in there use (orientations: ...) rather than (orientation: ...) - note the pluralisation in the word orientations. I believe the singular form is the correct version, see here: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/orientation

What is the current behavior?

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

To improve the product

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

P1Urgent issue that should be resolved before the next re-leasebughas prA PR has been created to address this issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions