Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add responsive support for ngClass and ngStyle #170

Merged
merged 3 commits into from
Feb 9, 2017
Merged

feat(api): add responsive support for ngClass and ngStyle #170

merged 3 commits into from
Feb 9, 2017

Conversation

joanllenas
Copy link
Contributor

@joanllenas joanllenas commented Feb 8, 2017 •
edited
Loading

@ThomasBurleson - The new PR is ready for reviewing

@joanllenas joanllenas mentioned this pull request Feb 8, 2017
Closed
@joanllenas
Copy link
Contributor Author

btw, I figured out what the issues were, hence the passing build.
I messed up my commits in the previous PR, and I couldn't even find what was wrong...

@ThomasBurleson
Copy link
Contributor

@joanllenas - Let me add some unit tests and this will be a GREAT addition to the library. Nice work sir!

@joanllenas
Copy link
Contributor Author

@ThomasBurleson - perfect! thanks for your time and guidance.

@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer pr: needs presubmit labels Feb 8, 2017
@ThomasBurleson
Copy link
Contributor

@joanllenas - great addition to this library. Thx again.

@ThomasBurleson ThomasBurleson force-pushed the feat/responsive-class-style branch from cd13487 to 7db4a29 Compare February 8, 2017 23:24
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: yes labels Feb 8, 2017
@ThomasBurleson ThomasBurleson removed pr: needs rebase cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Feb 8, 2017
@ThomasBurleson ThomasBurleson force-pushed the feat/responsive-class-style branch from 7db4a29 to dedd1cb Compare February 9, 2017 00:03
@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Feb 9, 2017
@tinayuangao tinayuangao merged commit f57a63d into master Feb 9, 2017
@joshwiens
Copy link
Contributor

@joanllenas - Playing with this in one of my projects now, great addition.

@joanllenas
Copy link
Contributor Author

Thanks, @d3viant0ne :)

@ThomasBurleson ThomasBurleson deleted the feat/responsive-class-style branch February 9, 2017 14:34
karlhaas pushed a commit to karlhaas/flex-layout that referenced this pull request May 3, 2017
@joanllenas @karlhaas
feat(api): add responsive support for ngClass and ngStyle (angular#170)
1d5b858 
* update(flexbox): refactor fxStyle and fxClass code

*  refactor code to `base-adapter.ts`

* update(flexbox): refactor fxStyle and fxClass code

*  refactor code to `base-adapter.ts`

* feat(api): add responsive support for ngClass and ngStyle
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ pr: lgtm This PR has been approved by the reviewer pr: needs presubmit pr: needs rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joanllenas @ThomasBurleson @googlebot @joshwiens @tinayuangao