This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
fix(core): only emit changed events from MediaObserver #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unfortunately the case in a real-world browser environment that overlapping breakpoints trigger separate events in our change monitoring schema. This is (nearly) unavoidable, but what we can do is ensure that we only emit distinct events for our event aggregator, MediaObserver. We now only emit when we get an entirely distinct set of media changes from the previous state.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unfortunately the case in a real-world browser environment
that overlapping breakpoints trigger separate events in our change
monitoring schema. This is (nearly) unavoidable, but what we can
do is ensure that we only emit distinct events for our event
aggregator, MediaObserver. We now only emit when we get an entirely
distinct set of media changes from the previous state.
Fixes #1041