Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use require.resolve instead of custom resolve #15906

Merged
merged 1 commit into from
Oct 23, 2019
Merged

refactor: use require.resolve instead of custom resolve #15906

merged 1 commit into from
Oct 23, 2019

Conversation

alan-agius4
Copy link
Collaborator

No description provided.

@alan-agius4
Copy link
Collaborator Author

This pr is sitting on top other commits which are going to master later today. Kindly check the last commit.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 22, 2019
@alan-agius4 alan-agius4 marked this pull request as ready for review October 22, 2019 12:37
@alan-agius4 alan-agius4 requested a review from clydin October 22, 2019 12:39
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 22, 2019
@vikerman
Copy link
Contributor

@alan-agius4 - Please rebase

@alan-agius4
Copy link
Collaborator Author

@vikerman, rebased.

@vikerman vikerman merged commit 70e460d into angular:master Oct 23, 2019
@alan-agius4 alan-agius4 deleted the resolve-replace branch October 23, 2019 17:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants