Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup initializers that use ctor params #58349

Closed
wants to merge 1 commit into from

Conversation

alxhub
Copy link
Member

@alxhub alxhub commented Oct 24, 2024

Fix initializer of instance members that reference identifiers declared in the constructor.

When public class fields are enabled, such cases throw TS2729: property used before its initialization.

Fix initializer of instance members that reference identifiers declared in
the constructor.

When public class fields are enabled, such cases throw TS2729: property used
before its initialization.
@pullapprove pullapprove bot requested a review from AndrewKushnir October 24, 2024 23:15
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate labels Oct 24, 2024
@alxhub
Copy link
Member Author

alxhub commented Oct 24, 2024

These changes were already tested in cl/653220229.

alxhub added a commit that referenced this pull request Oct 24, 2024
Fix initializer of instance members that reference identifiers declared in
the constructor.

When public class fields are enabled, such cases throw TS2729: property used
before its initialization.

PR Close #58349
@alxhub
Copy link
Member Author

alxhub commented Oct 24, 2024

This PR was merged into the repository by commit a264c78.

The changes were merged into the following branches: main, 19.0.x

@alxhub alxhub closed this in a264c78 Oct 24, 2024
JsantosDK pushed a commit to JsantosDK/angular that referenced this pull request Nov 11, 2024
Fix initializer of instance members that reference identifiers declared in
the constructor.

When public class fields are enabled, such cases throw TS2729: property used
before its initialization.

PR Close angular#58349
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants