Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete removal of aio subdirectory #56496

Closed
wants to merge 3 commits into from

Conversation

josephperrott
Copy link
Member

See individual commits.

Move windows-chromium-path help from aio to adev
Remove usage of aio example macro in adev
Finish removal of aio directory as it is no longer used or relied upon.
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: docs-infra Angular.dev application and infrastructure labels Jun 18, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 18, 2024
@josephperrott josephperrott marked this pull request as ready for review June 18, 2024 17:19
@josephperrott josephperrott removed the request for review from twerske June 18, 2024 17:24
@pkozlowski-opensource
Copy link
Member

Related: #56389

Copy link

Deployed adev-preview for 9e250c3 to: https://ng-dev-previews-fw--pr-angular-angular-56496-adev-prev-s4nz0unf.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen any breakage on ADEV induces by this change.
LGTM

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 0bd55a6.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 18, 2024
Move windows-chromium-path help from aio to adev

PR Close #56496
AndrewKushnir pushed a commit that referenced this pull request Jun 18, 2024
Remove usage of aio example macro in adev

PR Close #56496
AndrewKushnir pushed a commit that referenced this pull request Jun 18, 2024
Finish removal of aio directory as it is no longer used or relied upon.

PR Close #56496
AndrewKushnir pushed a commit that referenced this pull request Jun 18, 2024
Remove usage of aio example macro in adev

PR Close #56496
AndrewKushnir pushed a commit that referenced this pull request Jun 18, 2024
Finish removal of aio directory as it is no longer used or relied upon.

PR Close #56496
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2024
@josephperrott josephperrott deleted the remove-aio branch November 12, 2024 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure PullApprove: disable target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants