perf(common): AsyncPipe should not call markForCheck on subscription
#54554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: common
|
The single failure was due to a test that incorrectly relied on this behavior and is fixed in cl/609157155 |
This commit prevents `AsyncPipe` from calling `markForCheck` when values are synchronously emit during subscription to an observable. This prevents subscriptions to `Replay` observables from needlessly walking up to the root of the view tree during template execution for each new replay observable in the template.
alxhub
approved these changes
Feb 22, 2024
atscott
added
action: merge
|
Caretaker note: Might be a good idea to merge and sync on its own or at least with very unrelated changes. |
|
This PR was merged into the repository by commit 707bfc9. |
dylhunn
pushed a commit
that referenced
this pull request
Feb 23, 2024
…ion (#54554) This commit prevents `AsyncPipe` from calling `markForCheck` when values are synchronously emit during subscription to an observable. This prevents subscriptions to `Replay` observables from needlessly walking up to the root of the view tree during template execution for each new replay observable in the template. PR Close #54554
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents
AsyncPipefrom callingmarkForCheckwhen values are synchronously emit during subscription to an observable. This prevents subscriptions toReplayobservables from needlessly walking up to the root of the view tree during template execution for each new replay observable in the template.