Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): add Netlify image loader #54311

Closed
wants to merge 2 commits into from
Closed

feat(common): add Netlify image loader #54311

wants to merge 2 commits into from

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 7, 2024

Add an image loader for Netlify Image CDN. It is slightly different in implementation from existing loaders, because it allows absolute URLs.

Fixes #54303

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dylhunn February 7, 2024 14:01
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 7, 2024
@jessicajaniuk jessicajaniuk added the area: common Issues related to APIs in the @angular/common package label Feb 7, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 7, 2024
AndrewKushnir
AndrewKushnir reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascorbic thanks for creating this PR 👍

I've left a couple minor comments, please let me know if you have any questions.

packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts Outdated Show resolved Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts Show resolved Hide resolved
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Feb 8, 2024
@ascorbic
feat(common): add Netlify image loader
6d60b7c 
Add an image loader for Netlify Image CDN. It is slightly different in implementation from existing loaders, because it allows absolute URLs

Fixes angular#54303
@ascorbic
Copy link
Contributor Author

ascorbic commented Feb 8, 2024

@AndrewKushnir thanks for the review. I've pushed those changes and added a new test for the warn.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Feb 8, 2024 •
edited
Loading

@ascorbic thanks for addressing the feedback! FYI, I've added a fixup commit (d5cac8f) to avoid deep imports into @angular/core (it was triggering some errors).

AndrewKushnir
AndrewKushnir approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

jessicajaniuk
jessicajaniuk approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 8, 2024
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: presubmit The PR is in need of a google3 presubmit labels Feb 8, 2024
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 03c3b3e.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Support Netlify Image CDN in NgOptimizedImage
3 participants
@ascorbic @AndrewKushnir @jessicajaniuk