docs: Update docs about equality. #54158
Conversation
Since v17, `ngSwitch` uses a strict equality. Fixes angular#54156
JeanMeche
force-pushed
the
docs/ngswitch-equality
branch
from
c76c3a6 to
8ee1156
Compare
| @@ -192,8 +192,8 @@ export class NgSwitch { | |||
| * that defines the subtree to be selected if the value of the match expression | |||
| * matches the value of the switch expression. | |||
| * | |||
| * Unlike JavaScript, which uses strict equality, Angular uses loose equality. | |||
| * This means that the empty string, `""` matches 0. | |||
| * As of Angular v17 the NgSwitch directive uses strict equality comparison (`===`) instead of | |||
There was a problem hiding this comment.
I wonder if we need to mention v17 explicitly here. Normally the docs should reflect the current state (people can always access docs for the previous versions if needed).
There was a problem hiding this comment.
It puts the rest of the sentence into a context.
I've no strong feeling about, but if we remove the mention of the version I'd also remove the end the sentence.
There was a problem hiding this comment.
If it was not strict before v17, then this information is useful.
pkozlowski-opensource
added
action: merge
|
This PR was merged into the repository by commit 4a44f73. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Since v17,
ngSwitchuses a strict equality.Fixes #54156