Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(common): simplify date pipe metadata #53939

Closed
wants to merge 2 commits into from
Closed

refactor(common): simplify date pipe metadata #53939

wants to merge 2 commits into from

Conversation

kabrunko-dev
Copy link
Contributor

Simplify DatePipe metadata properties.

@dylhunn dylhunn added the area: common Issues related to APIs in the @angular/common package label Jan 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 17, 2024
@AndrewKushnir AndrewKushnir added the target: patch This PR is targeted for the next patch release label Jan 26, 2024
@AndrewKushnir
Copy link
Contributor

@kabrunko-dev thanks for creating this PR. Could you please update commit messages to include descriptions as described here?

@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 26, 2024
@kabrunko-dev
Copy link
Contributor Author

@kabrunko-dev thanks for creating this PR. Could you please update commit messages to include descriptions as described here?

Thank you for letting me help!

@AndrewKushnir
Copy link
Contributor

@kabrunko-dev I've noticed that you've updated one of two commits. Could you please update the second one as well? Thank you.

@kabrunko-dev
refactor(common): simplify date pipe metadata
9f0d12e 
Remove pure property from date pipe decorator
@kabrunko-dev
refactor(common): simplify i18n plural and select pipe metadata
676226f 
Remove pure property from pipe decorator
@kabrunko-dev
Copy link
Contributor Author

@kabrunko-dev I've noticed that you've updated one of two commits. [...]

@AndrewKushnir My fault

[...] Could you please update the second one as well? Thank you.

It's done! Thank you.

@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 29, 2024
@AndrewKushnir AndrewKushnir removed the request for review from atscott January 29, 2024 21:23
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Jan 29, 2024
jessicajaniuk pushed a commit that referenced this pull request Jan 30, 2024
@kabrunko-dev @thePunderWoman
refactor(common): simplify i18n plural and select pipe metadata (#53939)
f3567bb 
Remove pure property from pipe decorator

PR Close #53939
jessicajaniuk pushed a commit that referenced this pull request Jan 30, 2024
@kabrunko-dev @thePunderWoman
refactor(common): simplify date pipe metadata (#53939)
7a4a525 
Remove pure property from date pipe decorator

PR Close #53939
jessicajaniuk pushed a commit that referenced this pull request Jan 30, 2024
@kabrunko-dev @thePunderWoman
refactor(common): simplify i18n plural and select pipe metadata (#53939)
57174bb 
Remove pure property from pipe decorator

PR Close #53939
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit f3567bb.

nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
@kabrunko-dev @nikvarma
refactor(common): simplify date pipe metadata (angular#53939)
eb4ee5e 
Remove pure property from date pipe decorator

PR Close angular#53939
nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
@kabrunko-dev @nikvarma
refactor(common): simplify i18n plural and select pipe metadata (angu…
1ed0918 
…lar#53939)

Remove pure property from pipe decorator

PR Close angular#53939
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@kabrunko-dev @AndrewKushnir @jessicajaniuk @JeanMeche @dylhunn